summaryrefslogtreecommitdiff
path: root/test/parallel/test-http-client-race-2.js
diff options
context:
space:
mode:
authorBrian White <mscdex@mscdex.net>2016-05-29 03:06:56 -0400
committerBrian White <mscdex@mscdex.net>2016-06-10 22:30:55 -0400
commit2bc7841d0fcdd066fe477873229125b6f003b693 (patch)
tree2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-client-race-2.js
parent624734e640717a826ab1a18845c083a638dc5ce6 (diff)
downloadandroid-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz
android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2
android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-client-race-2.js')
-rw-r--r--test/parallel/test-http-client-race-2.js8
1 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-http-client-race-2.js b/test/parallel/test-http-client-race-2.js
index 0a98e06c7b..20b71f909a 100644
--- a/test/parallel/test-http-client-race-2.js
+++ b/test/parallel/test-http-client-race-2.js
@@ -1,5 +1,5 @@
'use strict';
-var common = require('../common');
+require('../common');
var assert = require('assert');
var http = require('http');
var url = require('url');
@@ -27,14 +27,14 @@ var server = http.createServer(function(req, res) {
{'Content-Type': 'text/plain', 'Content-Length': body.length});
res.end(body);
});
-server.listen(common.PORT);
+server.listen(0);
var body1 = '';
var body2 = '';
var body3 = '';
server.on('listening', function() {
- var client = http.createClient(common.PORT);
+ var client = http.createClient(this.address().port);
//
// Client #1 is assigned Parser #1
@@ -59,7 +59,7 @@ server.on('listening', function() {
// parser that previously belonged to Client #1. But we're not finished
// with Client #1 yet!
//
- var client2 = http.createClient(common.PORT);
+ var client2 = http.createClient(server.address().port);
//
// At this point, the bug would manifest itself and crash because the