test: improvements to various http tests

* Add common/countdown utility
* Numerous improvements to http tests

PR-URL: https://github.com/nodejs/node/pull/14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 files changed, 9 insertions, 8 deletions

diff --git a/test/parallel/test-http-client-abort2.js b/test/parallel/test-http-client-abort2.js
index e6804897ea..bc4b0e4083 100644
--- a/test/parallel/test-http-client-abort2.js
+++ b/test/parallel/test-http-client-abort2.js
@@ -20,18 +20,19 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+const common = require('../common');
 const http = require('http');
 
-const server = http.createServer(function(req, res) {
+const server = http.createServer(common.mustCall((req, res) => {
   res.end('Hello');
-});
+}));
 
-server.listen(0, function() {
-  const req = http.get({ port: this.address().port }, function(res) {
-    res.on('data', function(data) {
+server.listen(0, common.mustCall(() => {
+  const options = { port: server.address().port };
+  const req = http.get(options, common.mustCall((res) => {
+    res.on('data', (data) => {
       req.abort();
       server.close();
     });
-  });
-});
+  }));
+}));