test: improvements to various http tests

* Add common/countdown utility
* Numerous improvements to http tests

PR-URL: https://github.com/nodejs/node/pull/14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 files changed, 14 insertions, 30 deletions

diff --git a/test/parallel/test-http-buffer-sanity.js b/test/parallel/test-http-buffer-sanity.js
index a72d326d6f..8dfccf7d5c 100644
--- a/test/parallel/test-http-buffer-sanity.js
+++ b/test/parallel/test-http-buffer-sanity.js
@@ -32,16 +32,12 @@ for (let i = 0; i < buffer.length; i++) {
   buffer[i] = i % 256;
 }
 
-
-const web = http.Server(function(req, res) {
-  web.close();
-
-  console.log(req.headers);
+const server = http.Server(function(req, res) {
+  server.close();
 
   let i = 0;
 
-  req.on('data', function(d) {
-    process.stdout.write(',');
+  req.on('data', (d) => {
     measuredSize += d.length;
     for (let j = 0; j < d.length; j++) {
       assert.strictEqual(buffer[i], d[j]);
@@ -49,39 +45,27 @@ const web = http.Server(function(req, res) {
     }
   });
 
-
-  req.on('end', function() {
+  req.on('end', common.mustCall(() => {
+    assert.strictEqual(bufferSize, measuredSize);
     res.writeHead(200);
     res.write('thanks');
     res.end();
-    console.log('response with \'thanks\'');
-  });
-
-  req.connection.on('error', function(e) {
-    console.log(`http server-side error: ${e.message}`);
-    process.exit(1);
-  });
+  }));
 });
 
-web.listen(0, common.mustCall(function() {
-  console.log('Making request');
-
+server.listen(0, common.mustCall(() => {
   const req = http.request({
-    port: this.address().port,
-    method: 'GET',
+    port: server.address().port,
+    method: 'POST',
     path: '/',
     headers: { 'content-length': buffer.length }
-  }, common.mustCall(function(res) {
-    console.log('Got response');
+  }, common.mustCall((res) => {
     res.setEncoding('utf8');
-    res.on('data', common.mustCall(function(string) {
-      assert.strictEqual('thanks', string);
+    let data = '';
+    res.on('data', (chunk) => data += chunk);
+    res.on('end', common.mustCall(() => {
+      assert.strictEqual('thanks', data);
     }));
   }));
   req.end(buffer);
 }));
-
-
-process.on('exit', function() {
-  assert.strictEqual(bufferSize, measuredSize);
-});