aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-http-agent-error-on-idle.js
diff options
context:
space:
mode:
authorwillhayslett <william.hayslettjr@gmail.com>2018-03-21 20:22:44 -0500
committerTrivikram <16024985+trivikr@users.noreply.github.com>2018-03-24 19:42:42 -0700
commitd101942db9202460802bfa379322367e1e269d90 (patch)
tree7289fac8e8717a463d9a868c0c644b69da77012b /test/parallel/test-http-agent-error-on-idle.js
parent337e04054eedb3cedb27493adb02ca84d2c75005 (diff)
downloadandroid-node-v8-d101942db9202460802bfa379322367e1e269d90.tar.gz
android-node-v8-d101942db9202460802bfa379322367e1e269d90.tar.bz2
android-node-v8-d101942db9202460802bfa379322367e1e269d90.zip
test: remove message from assert.strictEqual()
Converted the 'message' argument values from the last two free socket assert.strictEqual() calls to code comments as they fail to provide the necessary details and values specific to why the test is failing. The default message returned from the strictEqual() call should provide sufficient details for debugging errors. PR-URL: https://github.com/nodejs/node/pull/19525 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-http-agent-error-on-idle.js')
-rw-r--r--test/parallel/test-http-agent-error-on-idle.js8
1 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-http-agent-error-on-idle.js b/test/parallel/test-http-agent-error-on-idle.js
index fce5e8f032..7cf494816a 100644
--- a/test/parallel/test-http-agent-error-on-idle.js
+++ b/test/parallel/test-http-agent-error-on-idle.js
@@ -27,8 +27,8 @@ server.listen(0, () => {
res.on('end', common.mustCall(() => {
process.nextTick(common.mustCall(() => {
const freeSockets = agent.freeSockets[socketKey];
- assert.strictEqual(freeSockets.length, 1,
- `expect a free socket on ${socketKey}`);
+ //expect a free socket on socketKey
+ assert.strictEqual(freeSockets.length, 1);
//generate a random error on the free socket
const freeSocket = freeSockets[0];
@@ -40,8 +40,8 @@ server.listen(0, () => {
}));
function done() {
- assert.strictEqual(Object.keys(agent.freeSockets).length, 0,
- 'expect the freeSockets pool to be empty');
+ //expect the freeSockets pool to be empty
+ assert.strictEqual(Object.keys(agent.freeSockets).length, 0);
agent.destroy();
server.close();