test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 26 insertions, 26 deletions

diff --git a/test/parallel/test-http-agent-error-on-idle.js b/test/parallel/test-http-agent-error-on-idle.js
index f609efc8d5..59b0109ef1 100644
--- a/test/parallel/test-http-agent-error-on-idle.js
+++ b/test/parallel/test-http-agent-error-on-idle.js
@@ -1,31 +1,27 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 var http = require('http');
 var Agent = http.Agent;
 
-var agent = new Agent({
-  keepAlive: true,
+var server = http.createServer(function(req, res) {
+  res.end('hello world');
 });
 
-var requestParams = {
-  host: 'localhost',
-  port: common.PORT,
-  agent: agent,
-  path: '/'
-};
-
-var socketKey = agent.getName(requestParams);
+server.listen(0, function() {
+  var agent = new Agent({
+    keepAlive: true,
+  });
 
-function get(callback) {
-  return http.get(requestParams, callback);
-}
+  var requestParams = {
+    host: 'localhost',
+    port: this.address().port,
+    agent: agent,
+    path: '/'
+  };
 
-var server = http.createServer(function(req, res) {
-  res.end('hello world');
-});
+  var socketKey = agent.getName(requestParams);
 
-server.listen(common.PORT, function() {
   get(function(res) {
     assert.equal(res.statusCode, 200);
     res.resume();
@@ -43,13 +39,17 @@ server.listen(common.PORT, function() {
       });
     });
   });
-});
 
-function done() {
-  assert.equal(Object.keys(agent.freeSockets).length, 0,
-               'expect the freeSockets pool to be empty');
+  function get(callback) {
+    return http.get(requestParams, callback);
+  }
 
-  agent.destroy();
-  server.close();
-  process.exit(0);
-}
+  function done() {
+    assert.equal(Object.keys(agent.freeSockets).length, 0,
+                 'expect the freeSockets pool to be empty');
+
+    agent.destroy();
+    server.close();
+    process.exit(0);
+  }
+});