test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 8 insertions, 4 deletions

diff --git a/test/parallel/test-http-1.0-keep-alive.js b/test/parallel/test-http-1.0-keep-alive.js
index fa49707c24..383f67c90a 100644
--- a/test/parallel/test-http-1.0-keep-alive.js
+++ b/test/parallel/test-http-1.0-keep-alive.js
@@ -1,5 +1,5 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var http = require('http');
 var net = require('net');
 
@@ -84,14 +84,17 @@ check([{
 
 function check(tests) {
   var test = tests[0];
-  if (test) http.createServer(server).listen(common.PORT, '127.0.0.1', client);
+  var server;
+  if (test) {
+    server = http.createServer(serverHandler).listen(0, '127.0.0.1', client);
+  }
   var current = 0;
 
   function next() {
     check(tests.slice(1));
   }
 
-  function server(req, res) {
+  function serverHandler(req, res) {
     if (current + 1 === test.responses.length) this.close();
     var ctx = test.responses[current];
     console.error('<  SERVER SENDING RESPONSE', ctx);
@@ -102,7 +105,8 @@ function check(tests) {
 
   function client() {
     if (current === test.requests.length) return next();
-    var conn = net.createConnection(common.PORT, '127.0.0.1', connected);
+    const port = server.address().port;
+    var conn = net.createConnection(port, '127.0.0.1', connected);
 
     function connected() {
       var ctx = test.requests[current];