summaryrefslogtreecommitdiff
path: root/test/parallel/test-fs-write-file-typedarrays.js
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-09-02 17:51:23 +0200
committerAnna Henningsen <anna@addaleax.net>2018-09-03 14:22:42 +0200
commitba43bce9e2383d445b9e669b34576ec4982d3f0d (patch)
treeeca8b614233b335d64d1d33be12969e9fa26835a /test/parallel/test-fs-write-file-typedarrays.js
parent64cf96d684cc8c713c8d12daeb2b0c68ab6dd760 (diff)
downloadandroid-node-v8-ba43bce9e2383d445b9e669b34576ec4982d3f0d.tar.gz
android-node-v8-ba43bce9e2383d445b9e669b34576ec4982d3f0d.tar.bz2
android-node-v8-ba43bce9e2383d445b9e669b34576ec4982d3f0d.zip
test: fix flaky parallel/test-fs-write-file-typedarrays
Using the same filename for different async tests could lead to race conditions. Example failure: https://travis-ci.com/nodejs/node/jobs/143351655 Refs: https://github.com/nodejs/node/pull/22150 PR-URL: https://github.com/nodejs/node/pull/22659 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-write-file-typedarrays.js')
-rw-r--r--test/parallel/test-fs-write-file-typedarrays.js5
1 files changed, 3 insertions, 2 deletions
diff --git a/test/parallel/test-fs-write-file-typedarrays.js b/test/parallel/test-fs-write-file-typedarrays.js
index e9bd9fe9a7..eca22750f6 100644
--- a/test/parallel/test-fs-write-file-typedarrays.js
+++ b/test/parallel/test-fs-write-file-typedarrays.js
@@ -32,10 +32,11 @@ for (const expectView of common.getArrayBufferViews(inputBuffer)) {
for (const expectView of common.getArrayBufferViews(inputBuffer)) {
console.log('Async test for ', expectView[Symbol.toStringTag]);
- fs.writeFile(filename, expectView, common.mustCall((e) => {
+ const file = `${filename}-${expectView[Symbol.toStringTag]}`;
+ fs.writeFile(file, expectView, common.mustCall((e) => {
assert.ifError(e);
- fs.readFile(filename, 'utf8', common.mustCall((err, data) => {
+ fs.readFile(file, 'utf8', common.mustCall((err, data) => {
assert.ifError(err);
assert.strictEqual(data, inputBuffer.toString('utf8'));
}));