diff options
author | Rich Trott <rtrott@gmail.com> | 2018-07-11 20:04:28 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-07-13 18:38:52 -0700 |
commit | 8c305e1c2fc94e3d0b3e6a016f5635970e287df7 (patch) | |
tree | 0170a38e3e77d3842e842d35de3a3f52b575d6e3 /test/parallel/test-fs-watch-file-enoent-after-deletion.js | |
parent | 39977db7c015e94d33885249f50e62fa8b1f1bb9 (diff) | |
download | android-node-v8-8c305e1c2fc94e3d0b3e6a016f5635970e287df7.tar.gz android-node-v8-8c305e1c2fc94e3d0b3e6a016f5635970e287df7.tar.bz2 android-node-v8-8c305e1c2fc94e3d0b3e6a016f5635970e287df7.zip |
test: fix flaky watchFile()
The regression that test-fs-watch-file-enoent-after-deletion was written
to test for involves whether or not the callback runs or not. Checking
what the file watcher reports unfortunately is subject to race
conditions on Windows (and possibly elsewhere) because the file watcher
returns control to the event loop before it may be receiving data from
the OS. So remove those assertions. The test still checks what it is
supposed to check, but is no longer subject to race conditions.
Fixes: https://github.com/nodejs/node/issues/21692
PR-URL: https://github.com/nodejs/node/pull/21694
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-fs-watch-file-enoent-after-deletion.js')
-rw-r--r-- | test/parallel/test-fs-watch-file-enoent-after-deletion.js | 48 |
1 files changed, 48 insertions, 0 deletions
diff --git a/test/parallel/test-fs-watch-file-enoent-after-deletion.js b/test/parallel/test-fs-watch-file-enoent-after-deletion.js new file mode 100644 index 0000000000..83c7516c9c --- /dev/null +++ b/test/parallel/test-fs-watch-file-enoent-after-deletion.js @@ -0,0 +1,48 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +'use strict'; +const common = require('../common'); + +// Make sure the deletion event gets reported in the following scenario: +// 1. Watch a file. +// 2. The initial stat() goes okay. +// 3. Something deletes the watched file. +// 4. The second stat() fails with ENOENT. + +// The second stat() translates into the first 'change' event but a logic error +// stopped it from getting emitted. +// https://github.com/nodejs/node-v0.x-archive/issues/4027 + +const path = require('path'); +const fs = require('fs'); + +const tmpdir = require('../common/tmpdir'); +tmpdir.refresh(); + +const filename = path.join(tmpdir.path, 'watched'); +fs.writeFileSync(filename, 'quis custodiet ipsos custodes'); + +fs.watchFile(filename, { interval: 50 }, common.mustCall(function(curr, prev) { + fs.unwatchFile(filename); +})); + +setTimeout(fs.unlinkSync, common.platformTimeout(300), filename); |