summaryrefslogtreecommitdiff
path: root/test/parallel/test-fs-stat.js
diff options
context:
space:
mode:
authorMyles Borins <mborins@us.ibm.com>2016-07-22 16:38:36 -0700
committerAnna Henningsen <anna@addaleax.net>2016-08-05 00:13:29 +0200
commit21b0a27af8b0a171f0a3a2a365259706bccfe1a5 (patch)
tree751489abda758420e504e1a20344264f7deda4e3 /test/parallel/test-fs-stat.js
parent1a9e247c794274942683d2e77db098c9494ddde5 (diff)
downloadandroid-node-v8-21b0a27af8b0a171f0a3a2a365259706bccfe1a5.tar.gz
android-node-v8-21b0a27af8b0a171f0a3a2a365259706bccfe1a5.tar.bz2
android-node-v8-21b0a27af8b0a171f0a3a2a365259706bccfe1a5.zip
Revert "fs: make callback mandatory to all async functions"
This reverts commit 9359de9dd2eae06ed5afcb75dad9bd4c466eb69d. Original Commit Message: The "fs" module has two functions called `maybeCallback` and `makeCallback`, as of now. The `maybeCallback` creates a default function to report errors, if the parameter passed is not a function object. Basically, if the callback is omitted in some cases, this function is used to create a default callback function. The `makeCallback`, OTOH, creates a default function only if the parameter passed is `undefined`, and if it is not a function object it will throw an `Error`. This patch removes the `maybeCallback` function and makes the callback function argument mandatory for all the async functions. PR-URL: https://github.com/nodejs/node/pull/7168 Reviewed-By: Trevor Norris <trev.norris@gmail.com> PR-URL: https://github.com/nodejs/node/pull/7846 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-stat.js')
-rw-r--r--test/parallel/test-fs-stat.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-fs-stat.js b/test/parallel/test-fs-stat.js
index 081ace714b..ac68a9ae42 100644
--- a/test/parallel/test-fs-stat.js
+++ b/test/parallel/test-fs-stat.js
@@ -28,7 +28,7 @@ fs.open('.', 'r', undefined, common.mustCall(function(err, fd) {
fs.fstat(fd, common.mustCall(function(err, stats) {
assert.ifError(err);
assert.ok(stats.mtime instanceof Date);
- fs.closeSync(fd);
+ fs.close(fd);
assert(this === global);
}));
@@ -47,7 +47,7 @@ fs.open('.', 'r', undefined, common.mustCall(function(err, fd) {
console.dir(stats);
assert.ok(stats.mtime instanceof Date);
}
- fs.closeSync(fd);
+ fs.close(fd);
}));
console.log(`stating: ${__filename}`);