fs: fs.read into zero buffer should not throw exception

Fixes: #4517.
PR-URL: https://github.com/nodejs/node/pull/4518
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 18 insertions, 0 deletions

diff --git a/test/parallel/test-fs-read-zero-length.js b/test/parallel/test-fs-read-zero-length.js
new file mode 100644
index 0000000000..9c4cde5236
--- /dev/null
+++ b/test/parallel/test-fs-read-zero-length.js
@@ -0,0 +1,18 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const path = require('path');
+const fs = require('fs');
+const filepath = path.join(common.fixturesDir, 'x.txt');
+const fd = fs.openSync(filepath, 'r');
+const expected = '';
+
+fs.read(fd, 0, 0, 'utf-8', common.mustCall(function(err, str, bytesRead) {
+  assert.ok(!err);
+  assert.equal(str, expected);
+  assert.equal(bytesRead, 0);
+}));
+
+const r = fs.readSync(fd, 0, 0, 'utf-8');
+assert.equal(r[0], expected);
+assert.equal(r[1], 0);