fs: Add string encoding option for Stream method

Add string encoding option for fs.createReadStream and
fs.createWriteStream. and check argument type more strictly

PR-URL: https://github.com/nodejs/io.js/pull/1845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 files changed, 33 insertions, 0 deletions

diff --git a/test/parallel/test-fs-read-stream-throw-type-error.js b/test/parallel/test-fs-read-stream-throw-type-error.js
new file mode 100644
index 0000000000..b3e63816ce
--- /dev/null
+++ b/test/parallel/test-fs-read-stream-throw-type-error.js
@@ -0,0 +1,33 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const fs = require('fs');
+const path = require('path');
+
+const example = path.join(common.fixturesDir, 'x.txt');
+
+assert.doesNotThrow(function() {
+  fs.createReadStream(example, undefined);
+});
+assert.doesNotThrow(function() {
+  fs.createReadStream(example, 'utf8');
+});
+assert.doesNotThrow(function() {
+  fs.createReadStream(example, {encoding: 'utf8'});
+});
+
+assert.throws(function() {
+  fs.createReadStream(example, null);
+}, /options must be a string or an object/);
+assert.throws(function() {
+  fs.createReadStream(example, 123);
+}, /options must be a string or an object/);
+assert.throws(function() {
+  fs.createReadStream(example, 0);
+}, /options must be a string or an object/);
+assert.throws(function() {
+  fs.createReadStream(example, true);
+}, /options must be a string or an object/);
+assert.throws(function() {
+  fs.createReadStream(example, false);
+}, /options must be a string or an object/);