diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-16 12:09:14 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-23 02:55:54 +0100 |
commit | 1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09 (patch) | |
tree | b708974383e0c32b07b1c1525b10ba8426307737 /test/parallel/test-fs-fchown.js | |
parent | c757cb1b9870de9297df736d5e831b7eb627644a (diff) | |
download | android-node-v8-1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09.tar.gz android-node-v8-1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09.tar.bz2 android-node-v8-1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09.zip |
errors: update error name
This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.
PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-fchown.js')
-rw-r--r-- | test/parallel/test-fs-fchown.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-fs-fchown.js b/test/parallel/test-fs-fchown.js index 500c06a47c..832dd071ea 100644 --- a/test/parallel/test-fs-fchown.js +++ b/test/parallel/test-fs-fchown.js @@ -18,7 +18,7 @@ function test(input, errObj) { ['', false, null, undefined, {}, []].forEach((input) => { const errObj = { code: 'ERR_INVALID_ARG_TYPE', - name: 'TypeError [ERR_INVALID_ARG_TYPE]', + name: 'TypeError', message: 'The "fd" argument must be of type number. Received type ' + typeof input }; @@ -28,7 +28,7 @@ function test(input, errObj) { [Infinity, NaN].forEach((input) => { const errObj = { code: 'ERR_OUT_OF_RANGE', - name: 'RangeError [ERR_OUT_OF_RANGE]', + name: 'RangeError', message: 'The value of "fd" is out of range. It must be an integer. ' + `Received ${input}` }; @@ -38,7 +38,7 @@ function test(input, errObj) { [-1, 2 ** 32].forEach((input) => { const errObj = { code: 'ERR_OUT_OF_RANGE', - name: 'RangeError [ERR_OUT_OF_RANGE]', + name: 'RangeError', message: 'The value of "fd" is out of range. It must be ' + `>= 0 && < 4294967296. Received ${input}` }; |