summaryrefslogtreecommitdiff
path: root/test/parallel/test-fs-chmod.js
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2017-08-18 13:03:20 -0700
committerJames M Snell <jasnell@gmail.com>2017-08-23 10:55:55 -0700
commit779a480bf171148a47fab6822076837825726746 (patch)
tree26c29734437859a3a52b50fdd29d84da8efb6506 /test/parallel/test-fs-chmod.js
parent58831b2f24a6b71b172e5f5876cb77096408142e (diff)
downloadandroid-node-v8-779a480bf171148a47fab6822076837825726746.tar.gz
android-node-v8-779a480bf171148a47fab6822076837825726746.tar.bz2
android-node-v8-779a480bf171148a47fab6822076837825726746.zip
test: do not modify fixtures in test-fs-chmod
`test-fs-chmod` modifies the permissions on files in `test/fixtures`. This change has the test use the temp directory instead. One of the fixture files is not used by any other test, so it has been deleted. I took this opportunity to remove `console.log()` statements from the test. PR-URL: https://github.com/nodejs/node/pull/14926 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-chmod.js')
-rw-r--r--test/parallel/test-fs-chmod.js17
1 files changed, 8 insertions, 9 deletions
diff --git a/test/parallel/test-fs-chmod.js b/test/parallel/test-fs-chmod.js
index de48b096c6..7d4b7a10db 100644
--- a/test/parallel/test-fs-chmod.js
+++ b/test/parallel/test-fs-chmod.js
@@ -71,14 +71,17 @@ if (common.isWindows) {
mode_sync = 0o644;
}
-const file1 = path.join(common.fixturesDir, 'a.js');
-const file2 = path.join(common.fixturesDir, 'a1.js');
+common.refreshTmpDir();
+
+const file1 = path.join(common.tmpDir, 'a.js');
+const file2 = path.join(common.tmpDir, 'a1.js');
+
+// Create file1.
+fs.closeSync(fs.openSync(file1, 'w'));
fs.chmod(file1, mode_async.toString(8), common.mustCall((err) => {
assert.ifError(err);
- console.log(fs.statSync(file1).mode);
-
if (common.isWindows) {
assert.ok((fs.statSync(file1).mode & 0o777) & mode_async);
} else {
@@ -93,14 +96,12 @@ fs.chmod(file1, mode_async.toString(8), common.mustCall((err) => {
}
}));
-fs.open(file2, 'a', common.mustCall((err, fd) => {
+fs.open(file2, 'w', common.mustCall((err, fd) => {
assert.ifError(err);
fs.fchmod(fd, mode_async.toString(8), common.mustCall((err) => {
assert.ifError(err);
- console.log(fs.fstatSync(fd).mode);
-
if (common.isWindows) {
assert.ok((fs.fstatSync(fd).mode & 0o777) & mode_async);
} else {
@@ -122,13 +123,11 @@ fs.open(file2, 'a', common.mustCall((err, fd) => {
if (fs.lchmod) {
const link = path.join(common.tmpDir, 'symbolic-link');
- common.refreshTmpDir();
fs.symlinkSync(file2, link);
fs.lchmod(link, mode_async, common.mustCall((err) => {
assert.ifError(err);
- console.log(fs.lstatSync(link).mode);
assert.strictEqual(mode_async, fs.lstatSync(link).mode & 0o777);
fs.lchmodSync(link, mode_sync);