summaryrefslogtreecommitdiff
path: root/test/parallel/test-fs-chmod-mask.js
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2018-05-26 18:51:19 +0800
committerAnna Henningsen <anna@addaleax.net>2018-06-01 11:12:10 +0200
commitcf723015458031fc80398971a0cfa0cbc9440004 (patch)
treea9d3bb16ae69d719180b76193db84215de6fefdb /test/parallel/test-fs-chmod-mask.js
parent38c938aa90a4346f0fc4e2ec77ebf180386f9ee5 (diff)
downloadandroid-node-v8-cf723015458031fc80398971a0cfa0cbc9440004.tar.gz
android-node-v8-cf723015458031fc80398971a0cfa0cbc9440004.tar.bz2
android-node-v8-cf723015458031fc80398971a0cfa0cbc9440004.zip
lib: unmask mode_t values with 0o777
This commit allows permission bits higher than 0o777 to go through the API (e.g. `S_ISVTX`=`0o1000`, `S_ISGID`=`0o2000`, `S_ISUID`=`0o4000`). Also documents that these bits are not exposed through `fs.constants` and their behaviors are platform-specific, so the users need to use them on their own risk. PR-URL: https://github.com/nodejs/node/pull/20975 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-chmod-mask.js')
-rw-r--r--test/parallel/test-fs-chmod-mask.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-fs-chmod-mask.js b/test/parallel/test-fs-chmod-mask.js
index 5f3a8d5ab8..9564ca142b 100644
--- a/test/parallel/test-fs-chmod-mask.js
+++ b/test/parallel/test-fs-chmod-mask.js
@@ -1,6 +1,6 @@
'use strict';
-// This tests that mode > 0o777 will be masked off with 0o777 in fs APIs.
+// This tests that the lower bits of mode > 0o777 still works in fs APIs.
const common = require('../common');
const assert = require('assert');