test: remove assert.doesNotThrow()

There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 files changed, 9 insertions, 13 deletions

diff --git a/test/parallel/test-fs-buffer.js b/test/parallel/test-fs-buffer.js
index bb10c164da..2d0bc2a557 100644
--- a/test/parallel/test-fs-buffer.js
+++ b/test/parallel/test-fs-buffer.js
@@ -9,22 +9,18 @@ const path = require('path');
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-assert.doesNotThrow(() => {
-  fs.access(Buffer.from(tmpdir.path), common.mustCall((err) => {
-    assert.ifError(err);
-  }));
-});
+fs.access(Buffer.from(tmpdir.path), common.mustCall((err) => {
+  assert.ifError(err);
+}));
 
-assert.doesNotThrow(() => {
-  const buf = Buffer.from(path.join(tmpdir.path, 'a.txt'));
-  fs.open(buf, 'w+', common.mustCall((err, fd) => {
+const buf = Buffer.from(path.join(tmpdir.path, 'a.txt'));
+fs.open(buf, 'w+', common.mustCall((err, fd) => {
+  assert.ifError(err);
+  assert(fd);
+  fs.close(fd, common.mustCall((err) => {
     assert.ifError(err);
-    assert(fd);
-    fs.close(fd, common.mustCall((err) => {
-      assert.ifError(err);
-    }));
   }));
-});
+}));
 
 common.expectsError(
   () => {