diff options
author | Rich Trott <rtrott@gmail.com> | 2017-02-07 20:44:53 -0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2017-02-09 20:48:48 -0800 |
commit | 05be62307df6d12e8489c220f7ee9a4f47a826c5 (patch) | |
tree | a1189686638c2728eb4c76985b721c241201c825 /test/parallel/test-fs-buffer.js | |
parent | 595df9fc4bb577b0f2a622cf23c1838445ef31f4 (diff) | |
download | android-node-v8-05be62307df6d12e8489c220f7ee9a4f47a826c5.tar.gz android-node-v8-05be62307df6d12e8489c220f7ee9a4f47a826c5.tar.bz2 android-node-v8-05be62307df6d12e8489c220f7ee9a4f47a826c5.zip |
test: refactor test-fs-buffer
* Remove unneeded temp dir cleanup
* Add check for error in `.close()` callback
* Improve error reporting
On that last bullet point, the previous version of the test reported
errors like this:
```
AssertionError: [ '.empty-repl-history-file',
'.node_repl_history',
'GH-1899-output.js',
'GH-892-request.js',
'a.js',
'a1.js',
'agen deepStrictEqual [ '.empty-repl-history-file',
'.node_repl_history',
'GH-1899-output.js',
'GH-892-request.js',
'a.js',
'a1.js',
'agen
```
Now, they look like this:
```
AssertionError: expected *, got ! by hex decoding 2a
```
PR-URL: https://github.com/nodejs/node/pull/11232
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-buffer.js')
-rw-r--r-- | test/parallel/test-fs-buffer.js | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/test/parallel/test-fs-buffer.js b/test/parallel/test-fs-buffer.js index 1452143a91..e7f575a437 100644 --- a/test/parallel/test-fs-buffer.js +++ b/test/parallel/test-fs-buffer.js @@ -18,8 +18,8 @@ assert.doesNotThrow(() => { fs.open(buf, 'w+', common.mustCall((err, fd) => { assert.ifError(err); assert(fd); - fs.close(fd, common.mustCall(() => { - fs.unlinkSync(buf); + fs.close(fd, common.mustCall((err) => { + assert.ifError(err); })); })); }); @@ -29,13 +29,17 @@ assert.throws(() => { }, /path must be a string or Buffer/); const dir = Buffer.from(common.fixturesDir); -fs.readdir(dir, 'hex', common.mustCall((err, list) => { +fs.readdir(dir, 'hex', common.mustCall((err, hexList) => { assert.ifError(err); - list = list.map((i) => { - return Buffer.from(i, 'hex').toString(); - }); - fs.readdir(dir, common.mustCall((err, list2) => { + fs.readdir(dir, common.mustCall((err, stringList) => { assert.ifError(err); - assert.deepStrictEqual(list, list2); + stringList.forEach((val, idx) => { + const fromHexList = Buffer.from(hexList[idx], 'hex').toString(); + assert.strictEqual( + fromHexList, + val, + `expected ${val}, got ${fromHexList} by hex decoding ${hexList[idx]}` + ); + }); })); })); |