summaryrefslogtreecommitdiff
path: root/test/parallel/test-force-repl.js
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2017-07-23 15:31:19 -0700
committerRich Trott <rtrott@gmail.com>2017-07-26 09:59:44 -0700
commit8f0102564e2110dc6a4a43fa9de29e9ead1e9cac (patch)
treeafcbaf71614041e9a02f479065057178b4db4c30 /test/parallel/test-force-repl.js
parentf7f590c9a9fe7bb31719f7fb7427e4de1a0d9edc (diff)
downloadandroid-node-v8-8f0102564e2110dc6a4a43fa9de29e9ead1e9cac.tar.gz
android-node-v8-8f0102564e2110dc6a4a43fa9de29e9ead1e9cac.tar.bz2
android-node-v8-8f0102564e2110dc6a4a43fa9de29e9ead1e9cac.zip
test: fix flaky test-force-repl
test/parallel/test-force-repl.js has an unnecessary timer that makes the test flaky under load. Remove it. PR-URL: https://github.com/nodejs/node/pull/14439 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-force-repl.js')
-rw-r--r--test/parallel/test-force-repl.js7
1 files changed, 2 insertions, 5 deletions
diff --git a/test/parallel/test-force-repl.js b/test/parallel/test-force-repl.js
index 03246d269d..15475a7e30 100644
--- a/test/parallel/test-force-repl.js
+++ b/test/parallel/test-force-repl.js
@@ -3,16 +3,13 @@ const common = require('../common');
const assert = require('assert');
const spawn = require('child_process').spawn;
-// spawn a node child process in "interactive" mode (force the repl)
+// Spawn a node child process in interactive mode (enabling the REPL) and
+// confirm the '> ' prompt is included in the output.
const cp = spawn(process.execPath, ['-i']);
-// give node + the repl 5 seconds to start
-const timeoutId = setTimeout(common.mustNotCall(),
- common.platformTimeout(5000));
cp.stdout.setEncoding('utf8');
cp.stdout.once('data', common.mustCall(function(b) {
- clearTimeout(timeoutId);
assert.strictEqual(b, '> ');
cp.kill();
}));