aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-event-emitter-check-listener-leaks.js
diff options
context:
space:
mode:
authorjseagull <jseagull@aliyun.com>2016-10-10 18:47:07 +0800
committerJames M Snell <jasnell@gmail.com>2016-10-26 12:59:53 -0700
commit254ab63832186ba2cfd87c9f2dfc0ce7a41a1989 (patch)
treeacb95af59cb0fa24eb54f31754935a30b6fd7443 /test/parallel/test-event-emitter-check-listener-leaks.js
parentf45eb1698ef920ccfd0aa5e861c68fd3e04e1e09 (diff)
downloadandroid-node-v8-254ab63832186ba2cfd87c9f2dfc0ce7a41a1989.tar.gz
android-node-v8-254ab63832186ba2cfd87c9f2dfc0ce7a41a1989.tar.bz2
android-node-v8-254ab63832186ba2cfd87c9f2dfc0ce7a41a1989.zip
events,test: fix TypeError in EventEmitter warning
Allows Symbol to be converted to String so it can be included in the error. Fixes: https://github.com/nodejs/node/issues/9003 PR-URL: https://github.com/nodejs/node/pull/9021 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Diffstat (limited to 'test/parallel/test-event-emitter-check-listener-leaks.js')
-rw-r--r--test/parallel/test-event-emitter-check-listener-leaks.js12
1 files changed, 10 insertions, 2 deletions
diff --git a/test/parallel/test-event-emitter-check-listener-leaks.js b/test/parallel/test-event-emitter-check-listener-leaks.js
index 1e357cd027..18d2d065b8 100644
--- a/test/parallel/test-event-emitter-check-listener-leaks.js
+++ b/test/parallel/test-event-emitter-check-listener-leaks.js
@@ -1,7 +1,7 @@
'use strict';
require('../common');
-var assert = require('assert');
-var events = require('events');
+const assert = require('assert');
+const events = require('events');
var e = new events.EventEmitter();
@@ -13,6 +13,14 @@ assert.ok(!e._events['default'].hasOwnProperty('warned'));
e.on('default', function() {});
assert.ok(e._events['default'].warned);
+// symbol
+const symbol = Symbol('symbol');
+e.setMaxListeners(1);
+e.on(symbol, function() {});
+assert.ok(!e._events[symbol].hasOwnProperty('warned'));
+e.on(symbol, function() {});
+assert.ok(e._events[symbol].hasOwnProperty('warned'));
+
// specific
e.setMaxListeners(5);
for (let i = 0; i < 5; i++) {