diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-18 13:20:58 +0100 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-21 05:35:12 +0100 |
commit | f17f4675440270d03b138d8ce55c1345230f6d2a (patch) | |
tree | 777c624e3cb042edeeeec0362ec530183dd9d837 /test/parallel/test-eslint-crypto-check.js | |
parent | 85df2c4703242679e409f648de95843f4a1f69a7 (diff) | |
download | android-node-v8-f17f4675440270d03b138d8ce55c1345230f6d2a.tar.gz android-node-v8-f17f4675440270d03b138d8ce55c1345230f6d2a.tar.bz2 android-node-v8-f17f4675440270d03b138d8ce55c1345230f6d2a.zip |
build,test: guard eslint with crypto check
Currently, configuring --without-ssl will cause the lint-js target to
fail with the following error:
$ make lint-js
Running JS linter...
internal/util.js:101
throw new ERR_NO_CRYPTO();
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
at assertCrypto (internal/util.js:101:11)
at crypto.js:31:1
...
(/node/tools/node_modules/eslint/node_modules/file-entry-cache/
cache.js:2:14)
at Module._compile (internal/modules/cjs/loader.js:746:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:757:10)
make: *** [lint-js] Error 1
There are also a number of tests that are affected in a similar way.
This commit adds crypto checks to allow for lint-js and the affected
tests to be skipped when configured --without-ssl.
PR-URL: https://github.com/nodejs/node/pull/26182
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-eslint-crypto-check.js')
-rw-r--r-- | test/parallel/test-eslint-crypto-check.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/parallel/test-eslint-crypto-check.js b/test/parallel/test-eslint-crypto-check.js index 2325a04354..0a973f4c9c 100644 --- a/test/parallel/test-eslint-crypto-check.js +++ b/test/parallel/test-eslint-crypto-check.js @@ -1,6 +1,8 @@ 'use strict'; const common = require('../common'); +if (!common.hasCrypto) + common.skip('missing crypto'); common.skipIfEslintMissing(); |