diff options
author | Masashi Hirano <cherrydog07@gmail.com> | 2018-07-27 08:11:04 +0900 |
---|---|---|
committer | Trivikram Kamat <16024985+trivikr@users.noreply.github.com> | 2018-08-06 23:53:21 -0700 |
commit | 0b85435c01cb1a6932a6b5b6cb6022d9dbf988e5 (patch) | |
tree | 897b1c831481e8434f80770b50529916b2dc60f9 /test/parallel/test-dns.js | |
parent | a4c1cf5f86e37ece7678f86188b0158c7f4f1f25 (diff) | |
download | android-node-v8-0b85435c01cb1a6932a6b5b6cb6022d9dbf988e5.tar.gz android-node-v8-0b85435c01cb1a6932a6b5b6cb6022d9dbf988e5.tar.bz2 android-node-v8-0b85435c01cb1a6932a6b5b6cb6022d9dbf988e5.zip |
test: check arg type for dnsPromises.resolve
PR-URL: https://github.com/nodejs/node/pull/22000
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test/parallel/test-dns.js')
-rw-r--r-- | test/parallel/test-dns.js | 33 |
1 files changed, 25 insertions, 8 deletions
diff --git a/test/parallel/test-dns.js b/test/parallel/test-dns.js index 3a44be9280..dcef59e43f 100644 --- a/test/parallel/test-dns.js +++ b/test/parallel/test-dns.js @@ -135,14 +135,31 @@ assert.deepStrictEqual(dns.getServers(), portsExpected); dns.setServers([]); assert.deepStrictEqual(dns.getServers(), []); -common.expectsError(() => { - dns.resolve('example.com', [], common.mustNotCall()); -}, { - code: 'ERR_INVALID_ARG_TYPE', - type: TypeError, - message: 'The "rrtype" argument must be of type string. ' + - 'Received type object' -}); +{ + const errObj = { + code: 'ERR_INVALID_ARG_TYPE', + type: TypeError, + message: 'The "rrtype" argument must be of type string. ' + + 'Received type object' + }; + common.expectsError(() => { + dns.resolve('example.com', [], common.mustNotCall()); + }, errObj); + common.expectsError(() => { + dnsPromises.resolve('example.com', []); + }, errObj); +} +{ + const errObj = { + code: 'ERR_INVALID_ARG_TYPE', + type: TypeError, + message: 'The "name" argument must be of type string. ' + + 'Received type undefined' + }; + common.expectsError(() => { + dnsPromises.resolve(); + }, errObj); +} // dns.lookup should accept only falsey and string values { |