diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-06-04 11:19:05 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2017-06-07 19:59:05 -0700 |
| commit | c20c57028211797b5ff5b3bc05d6eb05ab81ef9f (patch) | |
| tree | bbd8b6787e15a391b410c0eaa34a4ffefe7f6ad3 /test/parallel/test-dns-lookup.js | |
| parent | 8d2bd5fa88c9ebb9b1416d819b4a29b01c712424 (diff) | |
| download | android-node-v8-c20c57028211797b5ff5b3bc05d6eb05ab81ef9f.tar.gz android-node-v8-c20c57028211797b5ff5b3bc05d6eb05ab81ef9f.tar.bz2 android-node-v8-c20c57028211797b5ff5b3bc05d6eb05ab81ef9f.zip | |
test: check callback not invoked on lookup error
Use `common.mustNotCall()` to confirm that callback is not invoked when
`dns.lookup()` throws.
PR-URL: https://github.com/nodejs/node/pull/13456
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'test/parallel/test-dns-lookup.js')
| -rw-r--r-- | test/parallel/test-dns-lookup.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-dns-lookup.js b/test/parallel/test-dns-lookup.js index 9f56f21481..a1fad873e3 100644 --- a/test/parallel/test-dns-lookup.js +++ b/test/parallel/test-dns-lookup.js @@ -24,7 +24,7 @@ assert.throws(() => { hints: 100, family: 0, all: false - }, common.noop); + }, common.mustNotCall()); }, /^TypeError: Invalid argument: hints must use valid flags$/); assert.throws(() => { @@ -32,7 +32,7 @@ assert.throws(() => { hints: 0, family: 20, all: false - }, common.noop); + }, common.mustNotCall()); }, /^TypeError: Invalid argument: family must be 4 or 6$/); assert.doesNotThrow(() => { |