diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-dgram-udp4.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-dgram-udp4.js')
-rw-r--r-- | test/parallel/test-dgram-udp4.js | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/test/parallel/test-dgram-udp4.js b/test/parallel/test-dgram-udp4.js index 792aabb8c8..5902dab359 100644 --- a/test/parallel/test-dgram-udp4.js +++ b/test/parallel/test-dgram-udp4.js @@ -2,7 +2,6 @@ const common = require('../common'); const assert = require('assert'); const dgram = require('dgram'); -const server_port = common.PORT; const message_to_send = 'A message to send'; const server = dgram.createSocket('udp4'); @@ -13,9 +12,10 @@ server.on('message', common.mustCall((msg, rinfo) => { })); server.on('listening', common.mustCall(() => { const client = dgram.createSocket('udp4'); + const port = server.address().port; client.on('message', common.mustCall((msg, rinfo) => { assert.strictEqual(rinfo.address, common.localhostIPv4); - assert.strictEqual(rinfo.port, server_port); + assert.strictEqual(rinfo.port, port); assert.strictEqual(msg.toString(), message_to_send.toString()); client.close(); server.close(); @@ -23,10 +23,9 @@ server.on('listening', common.mustCall(() => { client.send(message_to_send, 0, message_to_send.length, - server_port, + port, 'localhost'); client.on('close', common.mustCall(() => {})); })); server.on('close', common.mustCall(() => {})); -server.bind(server_port); - +server.bind(0); |