summaryrefslogtreecommitdiff
path: root/test/parallel/test-dgram-send-callback-multi-buffer.js
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2016-10-26 20:56:08 -0700
committerRich Trott <rtrott@gmail.com>2016-10-29 13:11:01 -0700
commit6ef636c0c93e249f9da8bf060dc537667b9d3595 (patch)
tree93a4f9fb938aadc3e07ad859887fe331a1a036a1 /test/parallel/test-dgram-send-callback-multi-buffer.js
parentec7c27f4cb80c3f2600ec7e024276c2831273a47 (diff)
downloadandroid-node-v8-6ef636c0c93e249f9da8bf060dc537667b9d3595.tar.gz
android-node-v8-6ef636c0c93e249f9da8bf060dc537667b9d3595.tar.bz2
android-node-v8-6ef636c0c93e249f9da8bf060dc537667b9d3595.zip
test: fix freebsd10-64 CI failures
Remove unneeded timers from some tests and move others from parallel testing to sequential testing. This is to resolve test failures on freebsd10-64 on CI. The failures are all due to timers firing later than expected. Timers firing later than they are set for can happen on resource-constrained hosts and is not a bug. In general, it may be wise to put tests that depend on timing into sequential testing rather than parallel testing, as the timing can be affected by other simultaneously-running test processes. Fixes: https://github.com/nodejs/node/issues/8041 Fixes: https://github.com/nodejs/node/issues/9227 PR-URL: https://github.com/nodejs/node/pull/9317 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Diffstat (limited to 'test/parallel/test-dgram-send-callback-multi-buffer.js')
-rw-r--r--test/parallel/test-dgram-send-callback-multi-buffer.js5
1 files changed, 0 insertions, 5 deletions
diff --git a/test/parallel/test-dgram-send-callback-multi-buffer.js b/test/parallel/test-dgram-send-callback-multi-buffer.js
index 3004bfe39b..a60d42cc45 100644
--- a/test/parallel/test-dgram-send-callback-multi-buffer.js
+++ b/test/parallel/test-dgram-send-callback-multi-buffer.js
@@ -6,13 +6,8 @@ const dgram = require('dgram');
const client = dgram.createSocket('udp4');
-const timer = setTimeout(function() {
- throw new Error('Timeout');
-}, common.platformTimeout(200));
-
const messageSent = common.mustCall(function messageSent(err, bytes) {
assert.equal(bytes, buf1.length + buf2.length);
- clearTimeout(timer);
});
const buf1 = Buffer.alloc(256, 'x');