diff options
| author | Tobias Nießen <tniessen@tnie.de> | 2018-09-14 13:02:44 +0200 |
|---|---|---|
| committer | Tobias Nießen <tniessen@tnie.de> | 2018-09-19 18:31:28 +0200 |
| commit | 19ad6b8f72a9503d395d907bd9c190e816db3bed (patch) | |
| tree | 8eb7cf83bf3f6d310fba3603eb0efb623437b260 /test/parallel/test-crypto-pbkdf2.js | |
| parent | 92fd4fcd3d8496524e8ed1368314660b23d070bc (diff) | |
| download | android-node-v8-19ad6b8f72a9503d395d907bd9c190e816db3bed.tar.gz android-node-v8-19ad6b8f72a9503d395d907bd9c190e816db3bed.tar.bz2 android-node-v8-19ad6b8f72a9503d395d907bd9c190e816db3bed.zip | |
crypto: deprecate digest == null in PBKDF2
I assume that permitting digest === null was unintentional when
digest === undefined was deprecated since their behavior was
equivalent. The sha1 default for digest === null has somehow made it
through refactoring of the PBKDF2 module multiple times, even though
digest === undefined has been EOL for some time now.
This change deprecates setting digest to null so we can fix the
behavior in Node.js 12 or so.
PR-URL: https://github.com/nodejs/node/pull/22861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-crypto-pbkdf2.js')
| -rw-r--r-- | test/parallel/test-crypto-pbkdf2.js | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/test/parallel/test-crypto-pbkdf2.js b/test/parallel/test-crypto-pbkdf2.js index 0f5d4618ea..db12cf14fc 100644 --- a/test/parallel/test-crypto-pbkdf2.js +++ b/test/parallel/test-crypto-pbkdf2.js @@ -6,6 +6,11 @@ if (!common.hasCrypto) const assert = require('assert'); const crypto = require('crypto'); +common.expectWarning( + 'DeprecationWarning', + 'Calling pbkdf2 or pbkdf2Sync with "digest" set to null is deprecated.', + 'DEP0009'); + // // Test PBKDF2 with RFC 6070 test vectors (except #4) // @@ -64,7 +69,7 @@ assert.throws( ); assert.throws( - () => crypto.pbkdf2Sync('password', 'salt', -1, 20, null), + () => crypto.pbkdf2Sync('password', 'salt', -1, 20, 'sha1'), { code: 'ERR_OUT_OF_RANGE', name: 'RangeError [ERR_OUT_OF_RANGE]', |