test: remove assert.doesNotThrow()

There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 files changed, 10 insertions, 16 deletions

diff --git a/test/parallel/test-crypto-padding.js b/test/parallel/test-crypto-padding.js
index 6ad504d12c..ae85f7d2c3 100644
--- a/test/parallel/test-crypto-padding.js
+++ b/test/parallel/test-crypto-padding.js
@@ -100,11 +100,9 @@ assert.throws(function() {
   enc(ODD_LENGTH_PLAIN, false);
 }, /data not multiple of block length/);
 
-assert.doesNotThrow(function() {
-  assert.strictEqual(
-    enc(EVEN_LENGTH_PLAIN, false), EVEN_LENGTH_ENCRYPTED_NOPAD
-  );
-});
+assert.strictEqual(
+  enc(EVEN_LENGTH_PLAIN, false), EVEN_LENGTH_ENCRYPTED_NOPAD
+);
 
 
 /*
@@ -114,20 +112,16 @@ assert.doesNotThrow(function() {
 assert.strictEqual(dec(ODD_LENGTH_ENCRYPTED, true), ODD_LENGTH_PLAIN);
 assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED, true), EVEN_LENGTH_PLAIN);
 
-assert.doesNotThrow(function() {
-  // returns including original padding
-  assert.strictEqual(dec(ODD_LENGTH_ENCRYPTED, false).length, 32);
-  assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED, false).length, 48);
-});
+// returns including original padding
+assert.strictEqual(dec(ODD_LENGTH_ENCRYPTED, false).length, 32);
+assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED, false).length, 48);
 
 assert.throws(function() {
   // must have at least 1 byte of padding (PKCS):
   assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED_NOPAD, true), EVEN_LENGTH_PLAIN);
 }, /bad decrypt/);
 
-assert.doesNotThrow(function() {
-  // no-pad encrypted string should return the same:
-  assert.strictEqual(
-    dec(EVEN_LENGTH_ENCRYPTED_NOPAD, false), EVEN_LENGTH_PLAIN
-  );
-});
+// no-pad encrypted string should return the same:
+assert.strictEqual(
+  dec(EVEN_LENGTH_ENCRYPTED_NOPAD, false), EVEN_LENGTH_PLAIN
+);