crypto: move Decipher.finaltol to End-of-Life

Refs: https://github.com/nodejs/node/pull/19353

PR-URL: https://github.com/nodejs/node/pull/19941
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

1 files changed, 28 insertions, 33 deletions

diff --git a/test/parallel/test-crypto-padding-aes256.js b/test/parallel/test-crypto-padding-aes256.js
index 9fb80f3eed..ea31c7e894 100644
--- a/test/parallel/test-crypto-padding-aes256.js
+++ b/test/parallel/test-crypto-padding-aes256.js
@@ -29,39 +29,34 @@ const crypto = require('crypto');
 
 crypto.DEFAULT_ENCODING = 'buffer';
 
-function aes256(decipherFinal) {
-  const iv = Buffer.from('00000000000000000000000000000000', 'hex');
-  const key = Buffer.from('0123456789abcdef0123456789abcdef' +
-                          '0123456789abcdef0123456789abcdef', 'hex');
-
-  function encrypt(val, pad) {
-    const c = crypto.createCipheriv('aes256', key, iv);
-    c.setAutoPadding(pad);
-    return c.update(val, 'utf8', 'latin1') + c.final('latin1');
-  }
-
-  function decrypt(val, pad) {
-    const c = crypto.createDecipheriv('aes256', key, iv);
-    c.setAutoPadding(pad);
-    return c.update(val, 'latin1', 'utf8') + c[decipherFinal]('utf8');
-  }
-
-  // echo 0123456789abcdef0123456789abcdef \
-  // | openssl enc -e -aes256 -nopad -K <key> -iv <iv> \
-  // | openssl enc -d -aes256 -nopad -K <key> -iv <iv>
-  let plaintext = '0123456789abcdef0123456789abcdef'; // multiple of block size
-  let encrypted = encrypt(plaintext, false);
-  let decrypted = decrypt(encrypted, false);
-  assert.strictEqual(decrypted, plaintext);
+const iv = Buffer.from('00000000000000000000000000000000', 'hex');
+const key = Buffer.from('0123456789abcdef0123456789abcdef' +
+                        '0123456789abcdef0123456789abcdef', 'hex');
+
+function encrypt(val, pad) {
+  const c = crypto.createCipheriv('aes256', key, iv);
+  c.setAutoPadding(pad);
+  return c.update(val, 'utf8', 'latin1') + c.final('latin1');
+}
 
-  // echo 0123456789abcdef0123456789abcde \
-  // | openssl enc -e -aes256 -K <key> -iv <iv> \
-  // | openssl enc -d -aes256 -K <key> -iv <iv>
-  plaintext = '0123456789abcdef0123456789abcde'; // not a multiple
-  encrypted = encrypt(plaintext, true);
-  decrypted = decrypt(encrypted, true);
-  assert.strictEqual(decrypted, plaintext);
+function decrypt(val, pad) {
+  const c = crypto.createDecipheriv('aes256', key, iv);
+  c.setAutoPadding(pad);
+  return c.update(val, 'latin1', 'utf8') + c.final('utf8');
 }
 
-aes256('final');
-aes256('finaltol');
+// echo 0123456789abcdef0123456789abcdef \
+// | openssl enc -e -aes256 -nopad -K <key> -iv <iv> \
+// | openssl enc -d -aes256 -nopad -K <key> -iv <iv>
+let plaintext = '0123456789abcdef0123456789abcdef'; // multiple of block size
+let encrypted = encrypt(plaintext, false);
+let decrypted = decrypt(encrypted, false);
+assert.strictEqual(decrypted, plaintext);
+
+// echo 0123456789abcdef0123456789abcde \
+// | openssl enc -e -aes256 -K <key> -iv <iv> \
+// | openssl enc -d -aes256 -K <key> -iv <iv>
+plaintext = '0123456789abcdef0123456789abcde'; // not a multiple
+encrypted = encrypt(plaintext, true);
+decrypted = decrypt(encrypted, true);
+assert.strictEqual(decrypted, plaintext);