crypto: refactor the crypto module

* Split single monolithic file into multiple
* Make Certificate methods static
* Allow randomFill(Sync) to use any ArrayBufferView
* Use internal/errors throughout
* Improve arg validation in Hash/Hmac
* Doc updates

PR-URL: https://github.com/nodejs/node/pull/15231
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

1 files changed, 9 insertions, 14 deletions

diff --git a/test/parallel/test-crypto-hmac.js b/test/parallel/test-crypto-hmac.js
index 6ddffbf56f..a2921dae47 100644
--- a/test/parallel/test-crypto-hmac.js
+++ b/test/parallel/test-crypto-hmac.js
@@ -6,19 +6,11 @@ if (!common.hasCrypto)
 const assert = require('assert');
 const crypto = require('crypto');
 
-// Test for binding layer robustness
-{
-  const binding = process.binding('crypto');
-  const h = new binding.Hmac();
-  // Fail to init the Hmac with an algorithm.
-  assert.throws(() => h.update('hello'), /^TypeError: HmacUpdate fail$/);
-}
-
 // Test HMAC
 const h1 = crypto.createHmac('sha1', 'Node')
-               .update('some data')
-               .update('to hmac')
-               .digest('hex');
+                 .update('some data')
+                 .update('to hmac')
+                 .digest('hex');
 assert.strictEqual(h1, '19fd6e1ba73d9ed2224dd5094a71babe85d9a892', 'test HMAC');
 
 // Test HMAC (Wikipedia Test Cases)
@@ -376,9 +368,12 @@ for (let i = 0, l = rfc2202_sha1.length; i < l; i++) {
   );
 }
 
-assert.throws(function() {
-  crypto.createHmac('sha256', 'w00t').digest('ucs2');
-}, /^Error: hmac\.digest\(\) does not support UTF-16$/);
+common.expectsError(
+  () => crypto.createHmac('sha256', 'w00t').digest('ucs2'),
+  {
+    code: 'ERR_CRYPTO_HASH_DIGEST_NO_UTF16',
+    type: Error
+  });
 
 // Check initialized -> uninitialized state transition after calling digest().
 {