crypto: refactor the crypto module

* Split single monolithic file into multiple
* Make Certificate methods static
* Allow randomFill(Sync) to use any ArrayBufferView
* Use internal/errors throughout
* Improve arg validation in Hash/Hmac
* Doc updates

PR-URL: https://github.com/nodejs/node/pull/15231
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

1 files changed, 14 insertions, 7 deletions

diff --git a/test/parallel/test-crypto-engine.js b/test/parallel/test-crypto-engine.js
index b2fe154d3c..b731ec2f03 100644
--- a/test/parallel/test-crypto-engine.js
+++ b/test/parallel/test-crypto-engine.js
@@ -4,13 +4,20 @@ const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
 
-const assert = require('assert');
 const crypto = require('crypto');
 
-assert.throws(function() {
-  crypto.setEngine(true);
-}, /^TypeError: "id" argument should be a string$/);
+common.expectsError(
+  () => crypto.setEngine(true),
+  {
+    code: 'ERR_INVALID_ARG_TYPE',
+    type: TypeError,
+    message: 'The "id" argument must be of type string'
+  });
 
-assert.throws(function() {
-  crypto.setEngine('/path/to/engine', 'notANumber');
-}, /^TypeError: "flags" argument should be a number, if present$/);
+common.expectsError(
+  () => crypto.setEngine('/path/to/engine', 'notANumber'),
+  {
+    code: 'ERR_INVALID_ARG_TYPE',
+    type: TypeError,
+    message: 'The "flags" argument must be of type number'
+  });