diff options
| author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2017-04-28 04:06:42 +0300 |
|---|---|---|
| committer | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2017-05-05 17:39:05 +0300 |
| commit | 8b76c3e60c7b5c274c757257580a2c0faae69097 (patch) | |
| tree | a9f686995887dbeb0b5c5b23c5f3188987c99b2e /test/parallel/test-crypto-binary-default.js | |
| parent | 6bcf65d4a788a73b3c3f27d75796609f948f7885 (diff) | |
| download | android-node-v8-8b76c3e60c7b5c274c757257580a2c0faae69097.tar.gz android-node-v8-8b76c3e60c7b5c274c757257580a2c0faae69097.tar.bz2 android-node-v8-8b76c3e60c7b5c274c757257580a2c0faae69097.zip | |
test: reduce string concatenations
PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Diffstat (limited to 'test/parallel/test-crypto-binary-default.js')
| -rw-r--r-- | test/parallel/test-crypto-binary-default.js | 27 |
1 files changed, 11 insertions, 16 deletions
diff --git a/test/parallel/test-crypto-binary-default.js b/test/parallel/test-crypto-binary-default.js index 0ee11577d2..e92f70035b 100644 --- a/test/parallel/test-crypto-binary-default.js +++ b/test/parallel/test-crypto-binary-default.js @@ -37,17 +37,16 @@ const fs = require('fs'); const path = require('path'); const tls = require('tls'); const DH_NOT_SUITABLE_GENERATOR = crypto.constants.DH_NOT_SUITABLE_GENERATOR; +const fixtDir = common.fixturesDir; crypto.DEFAULT_ENCODING = 'latin1'; // Test Certificates -const certPem = fs.readFileSync(common.fixturesDir + '/test_cert.pem', 'ascii'); -const certPfx = fs.readFileSync(common.fixturesDir + '/test_cert.pfx'); -const keyPem = fs.readFileSync(common.fixturesDir + '/test_key.pem', 'ascii'); -const rsaPubPem = fs.readFileSync(common.fixturesDir + '/test_rsa_pubkey.pem', - 'ascii'); -const rsaKeyPem = fs.readFileSync(common.fixturesDir + '/test_rsa_privkey.pem', - 'ascii'); +const certPem = fs.readFileSync(`${fixtDir}/test_cert.pem`, 'ascii'); +const certPfx = fs.readFileSync(`${fixtDir}/test_cert.pfx`); +const keyPem = fs.readFileSync(`${fixtDir}/test_key.pem`, 'ascii'); +const rsaPubPem = fs.readFileSync(`${fixtDir}/test_rsa_pubkey.pem`, 'ascii'); +const rsaKeyPem = fs.readFileSync(`${fixtDir}/test_rsa_privkey.pem`, 'ascii'); // PFX tests assert.doesNotThrow(function() { @@ -408,7 +407,7 @@ const h2 = crypto.createHash('sha1').update('Test').update('123').digest('hex'); assert.strictEqual(h1, h2, 'multipled updates'); // Test hashing for binary files -const fn = path.join(common.fixturesDir, 'sample.png'); +const fn = path.join(fixtDir, 'sample.png'); const sha1Hash = crypto.createHash('sha1'); const fileStream = fs.createReadStream(fn); fileStream.on('data', function(data) { @@ -617,11 +616,9 @@ assert.strictEqual(rsaVerify.verify(rsaPubPem, rsaSignature, 'hex'), true); // Test RSA signing and verification // { - const privateKey = fs.readFileSync( - common.fixturesDir + '/test_rsa_privkey_2.pem'); + const privateKey = fs.readFileSync(`${fixtDir}/test_rsa_privkey_2.pem`); - const publicKey = fs.readFileSync( - common.fixturesDir + '/test_rsa_pubkey_2.pem'); + const publicKey = fs.readFileSync(`${fixtDir}/test_rsa_pubkey_2.pem`); const input = 'I AM THE WALRUS'; @@ -649,11 +646,9 @@ assert.strictEqual(rsaVerify.verify(rsaPubPem, rsaSignature, 'hex'), true); // Test DSA signing and verification // { - const privateKey = fs.readFileSync( - common.fixturesDir + '/test_dsa_privkey.pem'); + const privateKey = fs.readFileSync(`${fixtDir}/test_dsa_privkey.pem`); - const publicKey = fs.readFileSync( - common.fixturesDir + '/test_dsa_pubkey.pem'); + const publicKey = fs.readFileSync(`${fixtDir}/test_dsa_pubkey.pem`); const input = 'I AM THE WALRUS'; |