diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-09-13 13:19:06 -0700 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-10-01 11:11:18 -0700 |
| commit | 3473e58fee153a7fee143a33c512ee9cda08d20a (patch) | |
| tree | cb8ca98a350ea0cf68a14232660144a16967f168 /test/parallel/test-crypto-binary-default.js | |
| parent | 1ca1e0163e62cd9df771a6f0809e30a3382c54b6 (diff) | |
| download | android-node-v8-3473e58fee153a7fee143a33c512ee9cda08d20a.tar.gz android-node-v8-3473e58fee153a7fee143a33c512ee9cda08d20a.tar.bz2 android-node-v8-3473e58fee153a7fee143a33c512ee9cda08d20a.zip | |
test: well-defined DH groups now verify clean
OpenSSL 1.1.1d no longer generates warnings for some DH groups that used
to be considered unsafe. See below for discussion. This is considered a
bug fix.
See:
- https://github.com/openssl/openssl/pull/9363
- https://github.com/openssl/openssl/pull/9363#discussion_r324802618
PR-URL: https://github.com/nodejs/node/pull/29550
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-crypto-binary-default.js')
| -rw-r--r-- | test/parallel/test-crypto-binary-default.js | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/parallel/test-crypto-binary-default.js b/test/parallel/test-crypto-binary-default.js index c96253bc44..93ac0ef23e 100644 --- a/test/parallel/test-crypto-binary-default.js +++ b/test/parallel/test-crypto-binary-default.js @@ -36,7 +36,6 @@ const crypto = require('crypto'); const fs = require('fs'); const tls = require('tls'); const fixtures = require('../common/fixtures'); -const DH_NOT_SUITABLE_GENERATOR = crypto.constants.DH_NOT_SUITABLE_GENERATOR; require('internal/crypto/util').setDefaultEncoding('latin1'); @@ -615,8 +614,7 @@ common.expectsError( '020BBEA63B139B22514A08798E3404DDEF9519B3CD3A431B302B0A6DF25F1437' + '4FE1356D6D51C245E485B576625E7EC6F44C42E9A637ED6B0BFF5CB6F406B7ED' + 'EE386BFB5A899FA5AE9F24117C4B1FE649286651ECE65381FFFFFFFFFFFFFFFF'; - const d = crypto.createDiffieHellman(p, 'hex'); - assert.strictEqual(d.verifyError, DH_NOT_SUITABLE_GENERATOR); + crypto.createDiffieHellman(p, 'hex'); // Test RSA key signing/verification const rsaSign = crypto.createSign('SHA1'); |