summaryrefslogtreecommitdiff
path: root/test/parallel/test-common-countdown.js
diff options
context:
space:
mode:
authorBamieh <ahmadbamieh@gmail.com>2017-11-21 20:33:16 +0200
committerRuben Bridgewater <ruben@bridgewater.de>2018-02-16 18:32:59 +0100
commit941bc93f2229d4a28c3d3246878c7fd4fbf443ec (patch)
tree63db8a75e2e7940878ef308f205e6395a7e03f2e /test/parallel/test-common-countdown.js
parent96c57fbfaa8c1644648fa1414c9ad131b1320b60 (diff)
downloadandroid-node-v8-941bc93f2229d4a28c3d3246878c7fd4fbf443ec.tar.gz
android-node-v8-941bc93f2229d4a28c3d3246878c7fd4fbf443ec.tar.bz2
android-node-v8-941bc93f2229d4a28c3d3246878c7fd4fbf443ec.zip
test: wrap countdown callback in common.mustCall
This adds a implicit common.mustCall to the callback provided to the countdown. PR-URL: https://github.com/nodejs/node/pull/18506 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-common-countdown.js')
-rw-r--r--test/parallel/test-common-countdown.js22
1 files changed, 20 insertions, 2 deletions
diff --git a/test/parallel/test-common-countdown.js b/test/parallel/test-common-countdown.js
index ec0543f36f..6a1a2f1bbc 100644
--- a/test/parallel/test-common-countdown.js
+++ b/test/parallel/test-common-countdown.js
@@ -3,13 +3,31 @@
const common = require('../common');
const assert = require('assert');
const Countdown = require('../common/countdown');
+const fixtures = require('../common/fixtures');
+const { execFile } = require('child_process');
let done = '';
-
-const countdown = new Countdown(2, common.mustCall(() => done = true));
+const countdown = new Countdown(2, () => done = true);
assert.strictEqual(countdown.remaining, 2);
countdown.dec();
assert.strictEqual(countdown.remaining, 1);
countdown.dec();
assert.strictEqual(countdown.remaining, 0);
assert.strictEqual(done, true);
+
+const failFixtures = [
+ [
+ fixtures.path('failcounter.js'),
+ 'Mismatched <anonymous> function calls. Expected exactly 1, actual 0.',
+ ]
+];
+
+for (const p of failFixtures) {
+ const [file, expected] = p;
+ execFile(process.argv[0], [file], common.mustCall((ex, stdout, stderr) => {
+ assert.ok(ex);
+ assert.strictEqual(stderr, '');
+ const firstLine = stdout.split('\n').shift();
+ assert.strictEqual(firstLine, expected);
+ }));
+}