diff options
author | Sam Roberts <sam@strongloop.com> | 2015-01-10 03:23:06 +0100 |
---|---|---|
committer | Bert Belder <bertbelder@gmail.com> | 2015-01-10 04:50:40 +0100 |
commit | 092c224e08994e06cb64219ae371f32c477ea3bf (patch) | |
tree | 9ee6edef299ae098352daf72f6169906923aac93 /test/parallel/test-cluster-disconnect-before-exit.js | |
parent | 14310e681e2a6fc58f20e9d005e76a4e46f7439a (diff) | |
download | android-node-v8-092c224e08994e06cb64219ae371f32c477ea3bf.tar.gz android-node-v8-092c224e08994e06cb64219ae371f32c477ea3bf.tar.bz2 android-node-v8-092c224e08994e06cb64219ae371f32c477ea3bf.zip |
cluster: cluster.disconnect() should check status
Workers that are already disconnected but not yet exited should not be
disconnected, trying to do so raises exceptions.
PR-URL: https://github.com/joyent/node/pull/8642
Reviewed-by: Bert Belder <bertbelder@gmail.com>
Diffstat (limited to 'test/parallel/test-cluster-disconnect-before-exit.js')
-rw-r--r-- | test/parallel/test-cluster-disconnect-before-exit.js | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/test/parallel/test-cluster-disconnect-before-exit.js b/test/parallel/test-cluster-disconnect-before-exit.js new file mode 100644 index 0000000000..f952ddb764 --- /dev/null +++ b/test/parallel/test-cluster-disconnect-before-exit.js @@ -0,0 +1,35 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var cluster = require('cluster'); + +if (cluster.isMaster) { + var worker = cluster.fork().on('online', disconnect); + + function disconnect() { + worker.disconnect(); + // The worker remains in cluster.workers until both disconnect AND exit. + // Disconnect is supposed to disconnect all workers, but not workers that + // are already disconnected, since calling disconnect() on an already + // disconnected worker would error. + worker.on('disconnect', cluster.disconnect); + } +} |