test: remove common.PORT from test-cluster-basic

Use of `common.PORT` in `parallel` tests is not completely safe (because
the same port can be previously assigned to another test running in
parallel if that test uses port `0` to get an arbitrary available port).

Remove `common.PORT` from test-cluster-basic.

PR-URL: https://github.com/nodejs/node/pull/12377
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 10 insertions, 9 deletions

diff --git a/test/parallel/test-cluster-basic.js b/test/parallel/test-cluster-basic.js
index 1d9682400b..443eb23e6a 100644
--- a/test/parallel/test-cluster-basic.js
+++ b/test/parallel/test-cluster-basic.js
@@ -35,10 +35,7 @@ function forEach(obj, fn) {
 
 
 if (cluster.isWorker) {
-  const http = require('http');
-  http.Server(function() {
-
-  }).listen(common.PORT, '127.0.0.1');
+  require('http').Server(common.noop).listen(0, '127.0.0.1');
 } else if (cluster.isMaster) {
 
   const checks = {
@@ -129,11 +126,15 @@ if (cluster.isWorker) {
 
         case 'listening':
           assert.strictEqual(arguments.length, 1);
-          const expect = { address: '127.0.0.1',
-                           port: common.PORT,
-                           addressType: 4,
-                           fd: undefined };
-          assert.deepStrictEqual(arguments[0], expect);
+          assert.strictEqual(Object.keys(arguments[0]).length, 4);
+          assert.strictEqual(arguments[0].address, '127.0.0.1');
+          assert.strictEqual(arguments[0].addressType, 4);
+          assert(arguments[0].hasOwnProperty('fd'));
+          assert.strictEqual(arguments[0].fd, undefined);
+          const port = arguments[0].port;
+          assert(Number.isInteger(port));
+          assert(port >= 1);
+          assert(port <= 65535);
           break;
 
         default: