diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-05-16 15:15:14 +0200 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2017-05-19 20:24:41 +0200 |
| commit | 46e773c5db9ebc106823594b82f4ff14a0a004f3 (patch) | |
| tree | 3db561120aac67b90f67c3e0102bf6885f80a050 /test/parallel/test-cli-node-options.js | |
| parent | 6f216710eb49436f0c372fbaf6da3e65ba9578c2 (diff) | |
| download | android-node-v8-46e773c5db9ebc106823594b82f4ff14a0a004f3.tar.gz android-node-v8-46e773c5db9ebc106823594b82f4ff14a0a004f3.tar.bz2 android-node-v8-46e773c5db9ebc106823594b82f4ff14a0a004f3.zip | |
src: check if --icu-data-dir= points to valid dir
Call uc_init() after u_setDataDirectory() to find out if the data
directory is actually valid.
This commit removes parallel/test-intl-no-icu-data, added in commit
46345b9 ("src: make --icu-data-dir= switch testable"). It no longer
works now that an invalid --icu-data-dir= argument is rejected.
Coverage is now provided by parallel/test-icu-data-dir.
Fixes: https://github.com/nodejs/node/issues/13043
Refs: https://github.com/nodejs/node-gyp/issues/1199
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Diffstat (limited to 'test/parallel/test-cli-node-options.js')
| -rw-r--r-- | test/parallel/test-cli-node-options.js | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js index 6b0b9f53f9..bff0471808 100644 --- a/test/parallel/test-cli-node-options.js +++ b/test/parallel/test-cli-node-options.js @@ -57,7 +57,6 @@ if (common.hasCrypto) { expect('--use-bundled-ca', 'B\n'); expect('--openssl-config=_ossl_cfg', 'B\n'); } -expect('--icu-data-dir=_d', 'B\n'); // V8 options expect('--max_old_space_size=0', 'B\n'); |