diff options
| author | cjihrig <cjihrig@gmail.com> | 2018-06-13 12:05:55 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2018-06-20 11:02:01 -0400 |
| commit | 420d8afe3db22ad703e74892f58f9e32d34ff699 (patch) | |
| tree | 526d6d66151efb8c5cf820b3b2c0c5af42eabd62 /test/parallel/test-child-process-spawnsync-shell.js | |
| parent | 99e6ecbb17fa9ffef8e77a043e44367810403dbd (diff) | |
| download | android-node-v8-420d8afe3db22ad703e74892f58f9e32d34ff699.tar.gz android-node-v8-420d8afe3db22ad703e74892f58f9e32d34ff699.tar.bz2 android-node-v8-420d8afe3db22ad703e74892f58f9e32d34ff699.zip | |
child_process: change windowsHide default to true
This is likely the default that more Windows users are
expecting.
PR-URL: https://github.com/nodejs/node/pull/21316
Refs: https://github.com/libuv/libuv/pull/1878
Refs: https://github.com/nodejs/node/pull/21314
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-child-process-spawnsync-shell.js')
| -rw-r--r-- | test/parallel/test-child-process-spawnsync-shell.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-child-process-spawnsync-shell.js b/test/parallel/test-child-process-spawnsync-shell.js index 3eba0ba869..637cb12a23 100644 --- a/test/parallel/test-child-process-spawnsync-shell.js +++ b/test/parallel/test-child-process-spawnsync-shell.js @@ -66,7 +66,7 @@ assert.strictEqual(env.stdout.toString().trim(), 'buzz'); assert.strictEqual(opts.options.shell, shell); assert.strictEqual(opts.options.file, opts.file); assert.deepStrictEqual(opts.options.args, opts.args); - assert.strictEqual(opts.options.windowsHide, undefined); + assert.strictEqual(opts.options.windowsHide, true); assert.strictEqual(opts.options.windowsVerbatimArguments, windowsVerbatim); }); |