diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2017-06-21 20:16:43 +0200 |
---|---|---|
committer | Tobias Nießen <tniessen@tnie.de> | 2017-06-28 20:00:25 +0200 |
commit | 1698c8e1655adaf19e13cc6a5e1a4a570735e16f (patch) | |
tree | 5b15f07a5eb36d5f3d00bd755eb4c598e3827ea8 /test/parallel/test-child-process-send-after-close.js | |
parent | 8ca9338655dc3635da0d8fe154c5262468eb545f (diff) | |
download | android-node-v8-1698c8e1655adaf19e13cc6a5e1a4a570735e16f.tar.gz android-node-v8-1698c8e1655adaf19e13cc6a5e1a4a570735e16f.tar.bz2 android-node-v8-1698c8e1655adaf19e13cc6a5e1a4a570735e16f.zip |
errors: fix and improve error types
1) Add missing lazy assert call
2) Remove obsolete error type
3) Name undocumented error type more appropriate
4) Consolidate error type style (rely on util.format
instead of using a function)
5) Uppercase the first letter from error messages
6) Improve some internal error parameters
PR-URL: https://github.com/nodejs/node/pull/13857
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'test/parallel/test-child-process-send-after-close.js')
-rw-r--r-- | test/parallel/test-child-process-send-after-close.js | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/test/parallel/test-child-process-send-after-close.js b/test/parallel/test-child-process-send-after-close.js index 78cf3b6697..5039767aeb 100644 --- a/test/parallel/test-child-process-send-after-close.js +++ b/test/parallel/test-child-process-send-after-close.js @@ -10,9 +10,11 @@ child.on('close', common.mustCall((code, signal) => { assert.strictEqual(code, 0); assert.strictEqual(signal, null); - function testError(err) { - assert.strictEqual(err.message, 'channel closed'); - } + const testError = common.expectsError({ + type: Error, + message: 'Channel closed', + code: 'ERR_IPC_CHANNEL_CLOSED' + }); child.on('error', common.mustCall(testError)); |