diff options
author | Yevgen Safronov <sejoker@gmail.com> | 2016-09-17 11:40:06 +0200 |
---|---|---|
committer | Ilkka Myller <ilkka.myller@nodefield.com> | 2016-09-21 00:00:56 +0300 |
commit | 4019c321d4b080269165d5ec1c753238a641bc4a (patch) | |
tree | c14b3f548f1fce9795c3a76af098d03ff5d00ba4 /test/parallel/test-child-process-exec-env.js | |
parent | 80620d866511b5e47acf718ea2ecd7656559327e (diff) | |
download | android-node-v8-4019c321d4b080269165d5ec1c753238a641bc4a.tar.gz android-node-v8-4019c321d4b080269165d5ec1c753238a641bc4a.tar.bz2 android-node-v8-4019c321d4b080269165d5ec1c753238a641bc4a.zip |
test: cleanup test-child-process-exec-env.js
Replace equal with strictEqual, use const instead of var and
improve test with use of assert.notStrictEqual
PR-URL: https://github.com/nodejs/node/pull/8600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Diffstat (limited to 'test/parallel/test-child-process-exec-env.js')
-rw-r--r-- | test/parallel/test-child-process-exec-env.js | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/test/parallel/test-child-process-exec-env.js b/test/parallel/test-child-process-exec-env.js index e80531e87e..6af3bea211 100644 --- a/test/parallel/test-child-process-exec-env.js +++ b/test/parallel/test-child-process-exec-env.js @@ -1,11 +1,11 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); -var exec = require('child_process').exec; -var success_count = 0; -var error_count = 0; -var response = ''; -var child; +const common = require('../common'); +const assert = require('assert'); +const exec = require('child_process').exec; +let success_count = 0; +let error_count = 0; +let response = ''; +let child; function after(err, stdout, stderr) { if (err) { @@ -13,10 +13,10 @@ function after(err, stdout, stderr) { console.log('error!: ' + err.code); console.log('stdout: ' + JSON.stringify(stdout)); console.log('stderr: ' + JSON.stringify(stderr)); - assert.equal(false, err.killed); + assert.strictEqual(false, err.killed); } else { success_count++; - assert.equal(true, stdout != ''); + assert.notStrictEqual('', stdout); } } @@ -33,7 +33,7 @@ child.stdout.on('data', function(chunk) { process.on('exit', function() { console.log('response: ', response); - assert.equal(1, success_count); - assert.equal(0, error_count); + assert.strictEqual(1, success_count); + assert.strictEqual(0, error_count); assert.ok(response.indexOf('HELLO=WORLD') >= 0); }); |