diff options
| author | Brian White <mscdex@mscdex.net> | 2018-11-06 18:16:16 -0500 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-08 15:22:19 -0800 |
| commit | 5c201b6d477525a080b11d1bd49a7c94fe81f8ac (patch) | |
| tree | 7d1a39a7e42ed8fe3dd70aadee3aa0d775f1336a /test/parallel/test-buffer-writeuint.js | |
| parent | 00d412d3b721a91ce7c53fa68f2c457aef3d10cc (diff) | |
| download | android-node-v8-5c201b6d477525a080b11d1bd49a7c94fe81f8ac.tar.gz android-node-v8-5c201b6d477525a080b11d1bd49a7c94fe81f8ac.tar.bz2 android-node-v8-5c201b6d477525a080b11d1bd49a7c94fe81f8ac.zip | |
buffer: fix writeUInt16BE range check
Fixes: https://github.com/nodejs/node/issues/24205
PR-URL: https://github.com/nodejs/node/pull/24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-buffer-writeuint.js')
| -rw-r--r-- | test/parallel/test-buffer-writeuint.js | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/test/parallel/test-buffer-writeuint.js b/test/parallel/test-buffer-writeuint.js index 999440114c..387aafd335 100644 --- a/test/parallel/test-buffer-writeuint.js +++ b/test/parallel/test-buffer-writeuint.js @@ -84,6 +84,18 @@ const assert = require('assert'); data.writeUInt16BE(value, 0); assert.ok(data.equals(new Uint8Array([0xff, 0x80, 0x43, 0x23]))); + + value = 0xfffff; + ['writeUInt16BE', 'writeUInt16LE'].forEach((fn) => { + assert.throws( + () => data[fn](value, 0), + { + code: 'ERR_OUT_OF_RANGE', + message: 'The value of "value" is out of range. ' + + `It must be >= 0 and <= 65535. Received ${value}` + } + ); + }); } // Test 32 bit |