diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-02 13:44:26 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-04-13 19:58:26 +0200 |
| commit | d5495e859c3aceab7f8a823e27950e715b746a35 (patch) | |
| tree | 8c47b93f2da7476a8a0310c78ff13d408e9d82e5 /test/parallel/test-buffer-writedouble.js | |
| parent | a25f56730e815794ff645a2a050da22343fa7d89 (diff) | |
| download | android-node-v8-d5495e859c3aceab7f8a823e27950e715b746a35.tar.gz android-node-v8-d5495e859c3aceab7f8a823e27950e715b746a35.tar.bz2 android-node-v8-d5495e859c3aceab7f8a823e27950e715b746a35.zip | |
buffer: use a default offset
If none is provided, use zero as a default offset for all read/write
operations on the buffer.
PR-URL: https://github.com/nodejs/node/pull/19749
Refs: https://github.com/nodejs/node/pull/18395
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-buffer-writedouble.js')
| -rw-r--r-- | test/parallel/test-buffer-writedouble.js | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/test/parallel/test-buffer-writedouble.js b/test/parallel/test-buffer-writedouble.js index 8f56e93f73..0dc26dbd3b 100644 --- a/test/parallel/test-buffer-writedouble.js +++ b/test/parallel/test-buffer-writedouble.js @@ -80,6 +80,11 @@ assert.ok(Number.isNaN(buffer.readDoubleLE(8))); const small = Buffer.allocUnsafe(1); ['writeDoubleLE', 'writeDoubleBE'].forEach((fn) => { + + // Verify that default offset works fine. + buffer[fn](23, undefined); + buffer[fn](23); + assert.throws( () => small[fn](11.11, 0), { @@ -88,7 +93,7 @@ assert.ok(Number.isNaN(buffer.readDoubleLE(8))); message: 'Attempt to write outside buffer bounds' }); - ['', '0', null, undefined, {}, [], () => {}, true, false].forEach((off) => { + ['', '0', null, {}, [], () => {}, true, false].forEach((off) => { assert.throws( () => small[fn](23, off), { code: 'ERR_INVALID_ARG_TYPE' }); |