diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-16 12:09:14 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-23 02:55:54 +0100 |
commit | 1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09 (patch) | |
tree | b708974383e0c32b07b1c1525b10ba8426307737 /test/parallel/test-buffer-slow.js | |
parent | c757cb1b9870de9297df736d5e831b7eb627644a (diff) | |
download | android-node-v8-1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09.tar.gz android-node-v8-1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09.tar.bz2 android-node-v8-1ed3c54ecbd72a33693e5954f86bcc9fd9b1cc09.zip |
errors: update error name
This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.
PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'test/parallel/test-buffer-slow.js')
-rw-r--r-- | test/parallel/test-buffer-slow.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-buffer-slow.js b/test/parallel/test-buffer-slow.js index c9f5f17841..1dbc217bda 100644 --- a/test/parallel/test-buffer-slow.js +++ b/test/parallel/test-buffer-slow.js @@ -42,7 +42,7 @@ try { // Should throw with invalid length type const bufferInvalidTypeMsg = { code: 'ERR_INVALID_ARG_TYPE', - name: 'TypeError [ERR_INVALID_ARG_TYPE]', + name: 'TypeError', message: /^The "size" argument must be of type number/, }; assert.throws(() => SlowBuffer(), bufferInvalidTypeMsg); @@ -53,7 +53,7 @@ assert.throws(() => SlowBuffer(true), bufferInvalidTypeMsg); // Should throw with invalid length value const bufferMaxSizeMsg = { code: 'ERR_INVALID_OPT_VALUE', - name: 'RangeError [ERR_INVALID_OPT_VALUE]', + name: 'RangeError', message: /^The value "[^"]*" is invalid for option "size"$/ }; assert.throws(() => SlowBuffer(NaN), bufferMaxSizeMsg); |