diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-10 02:33:08 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-16 16:54:07 +0100 |
| commit | 644fdd60d4be49ffa66d0bda1702c4459f607635 (patch) | |
| tree | 70da98bc22a5a6c5bd0063e25d6eb729125706bf /test/parallel/test-buffer-slice.js | |
| parent | caee112e52b64f4bc1118c4a5fa5ad7b4211efea (diff) | |
| download | android-node-v8-644fdd60d4be49ffa66d0bda1702c4459f607635.tar.gz android-node-v8-644fdd60d4be49ffa66d0bda1702c4459f607635.tar.bz2 android-node-v8-644fdd60d4be49ffa66d0bda1702c4459f607635.zip | |
test: minor refactoring
Add punctuation and comments about code that should not throw.
Also remove a obsolete test and refactor some tests.
PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-buffer-slice.js')
| -rw-r--r-- | test/parallel/test-buffer-slice.js | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/test/parallel/test-buffer-slice.js b/test/parallel/test-buffer-slice.js index b55d082783..6175370a9b 100644 --- a/test/parallel/test-buffer-slice.js +++ b/test/parallel/test-buffer-slice.js @@ -77,9 +77,8 @@ expectedSameBufs.forEach(([buf1, buf2]) => { const utf16Buf = Buffer.from('0123456789', 'utf16le'); assert.deepStrictEqual(utf16Buf.slice(0, 6), Buffer.from('012', 'utf16le')); -// try to slice a zero length Buffer -// see https://github.com/joyent/node/issues/5881 -Buffer.alloc(0).slice(0, 1); +// Try to slice a zero length Buffer. +// See https://github.com/joyent/node/issues/5881 assert.strictEqual(Buffer.alloc(0).slice(0, 1).length, 0); { |