diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-01-02 16:10:57 -0800 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-01-05 12:40:26 +0100 |
| commit | 9fea7eae9a48c6c2e8fb75204a4e5c60e700a3e2 (patch) | |
| tree | ad364509fe82fb00bab194b68ac7f54d2c58a102 /test/parallel/test-buffer-read.js | |
| parent | 94d64877ff2b9d5fcfb40d24358337a95c333f66 (diff) | |
| download | android-node-v8-9fea7eae9a48c6c2e8fb75204a4e5c60e700a3e2.tar.gz android-node-v8-9fea7eae9a48c6c2e8fb75204a4e5c60e700a3e2.tar.bz2 android-node-v8-9fea7eae9a48c6c2e8fb75204a4e5c60e700a3e2.zip | |
buffer: check byteLength in readUInt(B|L)E
PR-URL: https://github.com/nodejs/node/pull/11146
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel/test-buffer-read.js')
| -rw-r--r-- | test/parallel/test-buffer-read.js | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/test/parallel/test-buffer-read.js b/test/parallel/test-buffer-read.js index c5b3373cbf..d024a32803 100644 --- a/test/parallel/test-buffer-read.js +++ b/test/parallel/test-buffer-read.js @@ -57,8 +57,14 @@ read(buf, 'readUInt32BE', [1], 0xfd48eacf); read(buf, 'readUInt32LE', [1], 0xcfea48fd); // testing basic functionality of readUIntBE() and readUIntLE() -read(buf, 'readUIntBE', [2, 0], 0xfd); -read(buf, 'readUIntLE', [2, 0], 0x48); +read(buf, 'readUIntBE', [2, 2], 0x48ea); +read(buf, 'readUIntLE', [2, 2], 0xea48); + +// invalid byteLength parameter for readUIntBE() and readUIntLE() +common.expectsError(() => { buf.readUIntBE(2, 0); }, + { code: 'ERR_OUT_OF_RANGE' }); +common.expectsError(() => { buf.readUIntLE(2, 7); }, + { code: 'ERR_OUT_OF_RANGE' }); // attempt to overflow buffers, similar to previous bug in array buffers assert.throws(() => Buffer.allocUnsafe(8).readFloatBE(0xffffffff), |