diff options
author | starkwang <381152119@qq.com> | 2017-06-28 23:58:39 -0400 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2017-07-12 17:00:30 -0400 |
commit | dbfe8c4ea2fb30f7d3dc4f8e361e3059b0e1e50f (patch) | |
tree | 35c3e4c7942fcb826e19f7a9eead918f9caa805b /test/parallel/test-buffer-from.js | |
parent | 1562fb9ea7b993382a4aef0433a10b1029419f17 (diff) | |
download | android-node-v8-dbfe8c4ea2fb30f7d3dc4f8e361e3059b0e1e50f.tar.gz android-node-v8-dbfe8c4ea2fb30f7d3dc4f8e361e3059b0e1e50f.tar.bz2 android-node-v8-dbfe8c4ea2fb30f7d3dc4f8e361e3059b0e1e50f.zip |
errors,buffer: port errors to internal/errors
PR-URL: https://github.com/nodejs/node/pull/13976
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Diffstat (limited to 'test/parallel/test-buffer-from.js')
-rw-r--r-- | test/parallel/test-buffer-from.js | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/test/parallel/test-buffer-from.js b/test/parallel/test-buffer-from.js index 1d8ecb5533..523d343f70 100644 --- a/test/parallel/test-buffer-from.js +++ b/test/parallel/test-buffer-from.js @@ -1,6 +1,6 @@ 'use strict'; -require('../common'); +const common = require('../common'); const { deepStrictEqual, throws } = require('assert'); const { Buffer } = require('buffer'); const { runInNewContext } = require('vm'); @@ -34,9 +34,6 @@ deepStrictEqual(Buffer.from( runInNewContext('new String(checkString)', {checkString})), check); -const err = new RegExp('^TypeError: First argument must be a string, Buffer, ' + - 'ArrayBuffer, Array, or array-like object\\.$'); - [ {}, new Boolean(true), @@ -45,6 +42,12 @@ const err = new RegExp('^TypeError: First argument must be a string, Buffer, ' + { valueOf: null }, Object.create(null) ].forEach((input) => { + const err = common.expectsError({ + code: 'ERR_INVALID_ARG_TYPE', + type: TypeError, + message: 'The first argument must be one of type string, buffer, ' + + 'arrayBuffer, array, or array-like object' + }); throws(() => Buffer.from(input), err); }); @@ -52,6 +55,11 @@ const err = new RegExp('^TypeError: First argument must be a string, Buffer, ' + new Number(true), new MyBadPrimitive() ].forEach((input) => { - throws(() => Buffer.from(input), - /^TypeError: "value" argument must not be a number$/); + const errMsg = common.expectsError({ + code: 'ERR_INVALID_ARG_TYPE', + type: TypeError, + message: 'The "value" argument must not be of type number. ' + + 'Received type number' + }); + throws(() => Buffer.from(input), errMsg); }); |