diff options
author | James M Snell <jasnell@gmail.com> | 2016-08-26 11:19:43 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-08-29 15:24:03 -0700 |
commit | 4537cf2377c9db383e9f8236a5e93c3b1b1fd008 (patch) | |
tree | 1fbfa24a93d9dbace304e9b493b587f8e1132659 /test/parallel/test-buffer-concat.js | |
parent | f10e1ed45511231817b44050d8c410ac5a2253be (diff) | |
download | android-node-v8-4537cf2377c9db383e9f8236a5e93c3b1b1fd008.tar.gz android-node-v8-4537cf2377c9db383e9f8236a5e93c3b1b1fd008.tar.bz2 android-node-v8-4537cf2377c9db383e9f8236a5e93c3b1b1fd008.zip |
test: additional refactoring/cleanup of buffer tests
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups
PR-URL: https://github.com/nodejs/node/pull/8283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaƫl Zasso <mic.besace@gmail.com>
Diffstat (limited to 'test/parallel/test-buffer-concat.js')
-rw-r--r-- | test/parallel/test-buffer-concat.js | 31 |
1 files changed, 17 insertions, 14 deletions
diff --git a/test/parallel/test-buffer-concat.js b/test/parallel/test-buffer-concat.js index a1dda865b6..3946b22141 100644 --- a/test/parallel/test-buffer-concat.js +++ b/test/parallel/test-buffer-concat.js @@ -1,24 +1,27 @@ 'use strict'; require('../common'); -var assert = require('assert'); +const assert = require('assert'); -var zero = []; -var one = [ Buffer.from('asdf') ]; -var long = []; +const zero = []; +const one = [ Buffer.from('asdf') ]; +const long = []; for (var i = 0; i < 10; i++) long.push(Buffer.from('asdf')); -var flatZero = Buffer.concat(zero); -var flatOne = Buffer.concat(one); -var flatLong = Buffer.concat(long); -var flatLongLen = Buffer.concat(long, 40); +const flatZero = Buffer.concat(zero); +const flatOne = Buffer.concat(one); +const flatLong = Buffer.concat(long); +const flatLongLen = Buffer.concat(long, 40); + +assert.strictEqual(flatZero.length, 0); +assert.strictEqual(flatOne.toString(), 'asdf'); + +const check = new Array(10 + 1).join('asdf'); -assert(flatZero.length === 0); -assert(flatOne.toString() === 'asdf'); // A special case where concat used to return the first item, // if the length is one. This check is to make sure that we don't do that. -assert(flatOne !== one[0]); -assert(flatLong.toString() === (new Array(10 + 1).join('asdf'))); -assert(flatLongLen.toString() === (new Array(10 + 1).join('asdf'))); +assert.notStrictEqual(flatOne, one[0]); +assert.strictEqual(flatLong.toString(), check); +assert.strictEqual(flatLongLen.toString(), check); assertWrongList(); assertWrongList(null); @@ -28,7 +31,7 @@ assertWrongList(['hello', 'world']); assertWrongList(['hello', Buffer.from('world')]); function assertWrongList(value) { - assert.throws(function() { + assert.throws(() => { Buffer.concat(value); }, function(err) { return err instanceof TypeError && |