diff options
author | Brian White <mscdex@mscdex.net> | 2016-09-08 18:31:39 -0400 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-09-11 21:11:49 -0700 |
commit | 73bafa0d8122b8cc5c027b401fdb29132bd18617 (patch) | |
tree | b5153f2aa50bf659af6ace2c128c17b559c05873 /test/parallel/test-buffer-bytelength.js | |
parent | cfe8278328d190279532ab9b7fd13ae1bfd78ee2 (diff) | |
download | android-node-v8-73bafa0d8122b8cc5c027b401fdb29132bd18617.tar.gz android-node-v8-73bafa0d8122b8cc5c027b401fdb29132bd18617.tar.bz2 android-node-v8-73bafa0d8122b8cc5c027b401fdb29132bd18617.zip |
buffer: fix ArrayBuffer checks
This commit fixes detection of ArrayBuffers from different V8 contexts.
This is especially a problem for environments like nw.js where the
node and browser V8 contexts are not shared.
PR-URL: https://github.com/nodejs/node/pull/8453
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'test/parallel/test-buffer-bytelength.js')
-rw-r--r-- | test/parallel/test-buffer-bytelength.js | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/test/parallel/test-buffer-bytelength.js b/test/parallel/test-buffer-bytelength.js index 521cff7d3b..14d7c95dd2 100644 --- a/test/parallel/test-buffer-bytelength.js +++ b/test/parallel/test-buffer-bytelength.js @@ -4,6 +4,7 @@ require('../common'); const assert = require('assert'); const Buffer = require('buffer').Buffer; const SlowBuffer = require('buffer').SlowBuffer; +const vm = require('vm'); // coerce values to string assert.strictEqual(Buffer.byteLength(32, 'latin1'), 2); @@ -87,3 +88,7 @@ assert.strictEqual(Buffer.byteLength('Il était tué', 'binary'), 12); ['ucs2', 'ucs-2', 'utf16le', 'utf-16le'].forEach(function(encoding) { assert.strictEqual(24, Buffer.byteLength('Il était tué', encoding)); }); + +// Test that ArrayBuffer from a different context is detected correctly +const arrayBuf = vm.runInNewContext('new ArrayBuffer()'); +assert.strictEqual(Buffer.byteLength(arrayBuf), 0); |