diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-11-10 16:59:16 +0800 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-11-19 13:43:59 +0100 |
| commit | efce655c0f1671d0e86b5c89092ac93db983ef94 (patch) | |
| tree | 26af173e687a6c8ee0f26d2857742ffce01729f2 /test/parallel/test-bootstrap-modules.js | |
| parent | 0f78dcc86d9af8f742f76505c5a104c6dff17ca9 (diff) | |
| download | android-node-v8-efce655c0f1671d0e86b5c89092ac93db983ef94.tar.gz android-node-v8-efce655c0f1671d0e86b5c89092ac93db983ef94.tar.bz2 android-node-v8-efce655c0f1671d0e86b5c89092ac93db983ef94.zip | |
module: reduce circular dependency of internal/modules/cjs/loader
Previously `internal/bootstrap/pre_execution.js` requires
`internal/modules/cjs/loader.js` which in turn requires
`internal/bootstrap/pre_execution.js`. This patch moves the
entry point execution logic out of `pre_execution.js` and
puts it into `internal/modules/run_main.js`. It also tests
that `Module.runMain` can be monkey-patched before further
deprecation/refactoring can be done.
Also added an internal assertion `hasLoadedAnyUserCJSModule`
for documentation purposes.
PR-URL: https://github.com/nodejs/node/pull/30349
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-bootstrap-modules.js')
| -rw-r--r-- | test/parallel/test-bootstrap-modules.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js index 40d37c3b8f..55a989a967 100644 --- a/test/parallel/test-bootstrap-modules.js +++ b/test/parallel/test-bootstrap-modules.js @@ -46,6 +46,7 @@ const expectedModules = new Set([ 'NativeModule internal/fs/utils', 'NativeModule internal/idna', 'NativeModule internal/linkedlist', + 'NativeModule internal/modules/run_main', 'NativeModule internal/modules/cjs/helpers', 'NativeModule internal/modules/cjs/loader', 'NativeModule internal/modules/esm/create_dynamic_module', |