diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-09-09 23:43:21 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-09-16 05:53:43 +0200 |
| commit | e095e645e52f14e135e80f0f910c812ca767ff31 (patch) | |
| tree | 18f00969db2edd08b7e23627a71f88ef3ecb15f4 /test/parallel/test-async-wrap-pop-id-during-load.js | |
| parent | 233cdb64a95eaabce922d773f3e312565e18a9d4 (diff) | |
| download | android-node-v8-e095e645e52f14e135e80f0f910c812ca767ff31.tar.gz android-node-v8-e095e645e52f14e135e80f0f910c812ca767ff31.tar.bz2 android-node-v8-e095e645e52f14e135e80f0f910c812ca767ff31.zip | |
src: print exceptions from PromiseRejectCallback
Previously, leaving the exception lying around would leave the JS
engine in an invalid state, as it was not expecting exceptions to
be thrown from the C++ `PromiseRejectCallback`, and lead to hard
crashes under some conditions (e.g. with coverage enabled).
PR-URL: https://github.com/nodejs/node/pull/29513
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-async-wrap-pop-id-during-load.js')
| -rw-r--r-- | test/parallel/test-async-wrap-pop-id-during-load.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-async-wrap-pop-id-during-load.js b/test/parallel/test-async-wrap-pop-id-during-load.js index 1ab9810479..bf75451817 100644 --- a/test/parallel/test-async-wrap-pop-id-during-load.js +++ b/test/parallel/test-async-wrap-pop-id-during-load.js @@ -23,4 +23,4 @@ assert.strictEqual(ret.status, 0, `EXIT CODE: ${ret.status}, STDERR:\n${ret.stderr}`); const stderr = ret.stderr.toString('utf8', 0, 2048); assert.ok(!/async.*hook/i.test(stderr)); -assert.ok(stderr.includes('UnhandledPromiseRejectionWarning: Error'), stderr); +assert.ok(stderr.includes('Maximum call stack size exceeded'), stderr); |