assert: make `actual` and `expected` getters

The `actual` and `expected` properties on an instance of
`AssertionError` is now a getter to prevent inspecting these when
inspecting the error. These values will be visible in the error
message and showing them otherwise would decrease the readability
of the error.

PR-URL: https://github.com/nodejs/node/pull/25250
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 11 insertions, 0 deletions

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
index db00ed2836..bf2da0b5dd 100644
--- a/test/parallel/test-assert.js
+++ b/test/parallel/test-assert.js
@@ -1139,3 +1139,14 @@ assert.throws(
              '{\n  a: true\n}\n'
   }
 );
+
+{
+  let threw = false;
+  try {
+    assert.deepStrictEqual(Array(100).fill(1), 'foobar');
+  } catch (err) {
+    threw = true;
+    assert(/actual: \[Array],\n  expected: 'foobar',/.test(inspect(err)));
+  }
+  assert(threw);
+}