diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-12-02 13:12:52 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-12-07 00:43:51 +0100 |
| commit | 5360dd151da9d8b1c97785a0e394cc731af31f69 (patch) | |
| tree | f8bee2cd4810c7ee9e168fdfcb84397dca37c5ad /test/parallel/test-assert.js | |
| parent | b5f2942fb55055b5a8b5de290953f81d2e291005 (diff) | |
| download | android-node-v8-5360dd151da9d8b1c97785a0e394cc731af31f69.tar.gz android-node-v8-5360dd151da9d8b1c97785a0e394cc731af31f69.tar.bz2 android-node-v8-5360dd151da9d8b1c97785a0e394cc731af31f69.zip | |
assert: handle (deep) equal(NaN, NaN) as being identical
This aligns the `equal` and `deepEqual()` implementations with the
strict versions by accepting `NaN` as being identical in case both
sides are NaN.
Refs: https://github.com/nodejs/node/issues/30350#issuecomment-552191641
PR-URL: https://github.com/nodejs/node/pull/30766
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'test/parallel/test-assert.js')
| -rw-r--r-- | test/parallel/test-assert.js | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js index 48b44ce29b..3db63a816a 100644 --- a/test/parallel/test-assert.js +++ b/test/parallel/test-assert.js @@ -501,6 +501,12 @@ assert.throws( } ); +a.equal(NaN, NaN); +a.throws( + () => a.notEqual(NaN, NaN), + a.AssertionError +); + // Test strict assert. { const a = require('assert'); |