diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-03-20 12:39:46 +0100 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-03-26 10:29:34 +0200 |
commit | 8fb4ea9f75c8c82c46286bd5ca0c1115c4a5e956 (patch) | |
tree | 76c01165a604c4785043224d8b815984e2cda9b2 /test/parallel/test-assert-fail-deprecation.js | |
parent | ebbf3936001969905ce28dc588b2c71c3b65c146 (diff) | |
download | android-node-v8-8fb4ea9f75c8c82c46286bd5ca0c1115c4a5e956.tar.gz android-node-v8-8fb4ea9f75c8c82c46286bd5ca0c1115c4a5e956.tar.bz2 android-node-v8-8fb4ea9f75c8c82c46286bd5ca0c1115c4a5e956.zip |
test: add deprecation code to expectWarning
This commit adds a deprecation code to expectWarning and updates the
function to check the passed code against the code property on the
warning object.
Not all warnings have a deprecation code so for those that don't an
explicit code of common.noWarnCode is required. Passing this skips the
assertion of the code.
PR-URL: https://github.com/nodejs/node/pull/19474
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'test/parallel/test-assert-fail-deprecation.js')
-rw-r--r-- | test/parallel/test-assert-fail-deprecation.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/parallel/test-assert-fail-deprecation.js b/test/parallel/test-assert-fail-deprecation.js index aab26d4272..68ebcd612d 100644 --- a/test/parallel/test-assert-fail-deprecation.js +++ b/test/parallel/test-assert-fail-deprecation.js @@ -6,7 +6,8 @@ const assert = require('assert'); common.expectWarning( 'DeprecationWarning', 'assert.fail() with more than one argument is deprecated. ' + - 'Please use assert.strictEqual() instead or only pass a message.' + 'Please use assert.strictEqual() instead or only pass a message.', + 'DEP0094' ); // Two args only, operator defaults to '!=' |